Add workflow to enforce Datadog merge queue#10590
Conversation
|
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 58 metrics, 13 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.60.0-SNAPSHOT~7fc80d49ab, baseline=1.60.0-SNAPSHOT~f215026f2d
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.061 s) : 0, 1061452
Total [baseline] (8.771 s) : 0, 8770851
Agent [candidate] (1.065 s) : 0, 1064826
Total [candidate] (8.787 s) : 0, 8787493
section iast
Agent [baseline] (1.239 s) : 0, 1239364
Total [baseline] (9.371 s) : 0, 9371495
Agent [candidate] (1.241 s) : 0, 1241190
Total [candidate] (9.387 s) : 0, 9386642
gantt
title insecure-bank - break down per module: candidate=1.60.0-SNAPSHOT~7fc80d49ab, baseline=1.60.0-SNAPSHOT~f215026f2d
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.183 ms) : 0, 1183
crashtracking [candidate] (1.186 ms) : 0, 1186
BytebuddyAgent [baseline] (627.971 ms) : 0, 627971
BytebuddyAgent [candidate] (628.844 ms) : 0, 628844
AgentMeter [baseline] (28.954 ms) : 0, 28954
AgentMeter [candidate] (29.0 ms) : 0, 29000
GlobalTracer [baseline] (257.384 ms) : 0, 257384
GlobalTracer [candidate] (257.734 ms) : 0, 257734
AppSec [baseline] (32.786 ms) : 0, 32786
AppSec [candidate] (32.645 ms) : 0, 32645
Debugger [baseline] (61.958 ms) : 0, 61958
Debugger [candidate] (62.974 ms) : 0, 62974
Remote Config [baseline] (640.234 µs) : 0, 640
Remote Config [candidate] (630.874 µs) : 0, 631
Telemetry [baseline] (11.513 ms) : 0, 11513
Telemetry [candidate] (11.278 ms) : 0, 11278
Flare Poller [baseline] (3.753 ms) : 0, 3753
Flare Poller [candidate] (5.163 ms) : 0, 5163
section iast
crashtracking [baseline] (1.207 ms) : 0, 1207
crashtracking [candidate] (1.209 ms) : 0, 1209
BytebuddyAgent [baseline] (801.919 ms) : 0, 801919
BytebuddyAgent [candidate] (802.725 ms) : 0, 802725
AgentMeter [baseline] (11.465 ms) : 0, 11465
AgentMeter [candidate] (11.567 ms) : 0, 11567
GlobalTracer [baseline] (249.328 ms) : 0, 249328
GlobalTracer [candidate] (250.517 ms) : 0, 250517
AppSec [baseline] (34.136 ms) : 0, 34136
AppSec [candidate] (34.945 ms) : 0, 34945
Debugger [baseline] (66.084 ms) : 0, 66084
Debugger [candidate] (65.063 ms) : 0, 65063
Remote Config [baseline] (543.128 µs) : 0, 543
Remote Config [candidate] (564.095 µs) : 0, 564
Telemetry [baseline] (8.551 ms) : 0, 8551
Telemetry [candidate] (8.598 ms) : 0, 8598
Flare Poller [baseline] (3.481 ms) : 0, 3481
Flare Poller [candidate] (3.421 ms) : 0, 3421
IAST [baseline] (27.142 ms) : 0, 27142
IAST [candidate] (27.071 ms) : 0, 27071
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.60.0-SNAPSHOT~7fc80d49ab, baseline=1.60.0-SNAPSHOT~f215026f2d
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.072 s) : 0, 1072429
Total [baseline] (10.924 s) : 0, 10923535
Agent [candidate] (1.065 s) : 0, 1064984
Total [candidate] (10.914 s) : 0, 10914222
section appsec
Agent [baseline] (1.239 s) : 0, 1239241
Total [baseline] (11.17 s) : 0, 11170379
Agent [candidate] (1.249 s) : 0, 1249361
Total [candidate] (11.128 s) : 0, 11127823
section iast
Agent [baseline] (1.239 s) : 0, 1238646
Total [baseline] (11.264 s) : 0, 11264300
Agent [candidate] (1.233 s) : 0, 1233481
Total [candidate] (11.258 s) : 0, 11257711
section profiling
Agent [baseline] (1.193 s) : 0, 1192822
Total [baseline] (11.059 s) : 0, 11058743
Agent [candidate] (1.192 s) : 0, 1191661
Total [candidate] (11.073 s) : 0, 11073036
gantt
title petclinic - break down per module: candidate=1.60.0-SNAPSHOT~7fc80d49ab, baseline=1.60.0-SNAPSHOT~f215026f2d
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.193 ms) : 0, 1193
crashtracking [candidate] (1.178 ms) : 0, 1178
BytebuddyAgent [baseline] (633.065 ms) : 0, 633065
BytebuddyAgent [candidate] (628.391 ms) : 0, 628391
AgentMeter [baseline] (29.222 ms) : 0, 29222
AgentMeter [candidate] (28.813 ms) : 0, 28813
GlobalTracer [baseline] (259.414 ms) : 0, 259414
GlobalTracer [candidate] (257.459 ms) : 0, 257459
AppSec [baseline] (33.083 ms) : 0, 33083
AppSec [candidate] (32.724 ms) : 0, 32724
Debugger [baseline] (63.262 ms) : 0, 63262
Debugger [candidate] (65.304 ms) : 0, 65304
Remote Config [baseline] (627.782 µs) : 0, 628
Remote Config [candidate] (607.204 µs) : 0, 607
Telemetry [baseline] (12.387 ms) : 0, 12387
Telemetry [candidate] (10.597 ms) : 0, 10597
Flare Poller [baseline] (4.607 ms) : 0, 4607
Flare Poller [candidate] (4.569 ms) : 0, 4569
section appsec
crashtracking [baseline] (1.179 ms) : 0, 1179
crashtracking [candidate] (1.194 ms) : 0, 1194
BytebuddyAgent [baseline] (657.972 ms) : 0, 657972
BytebuddyAgent [candidate] (663.105 ms) : 0, 663105
AgentMeter [baseline] (11.967 ms) : 0, 11967
AgentMeter [candidate] (12.13 ms) : 0, 12130
GlobalTracer [baseline] (258.591 ms) : 0, 258591
GlobalTracer [candidate] (260.626 ms) : 0, 260626
AppSec [baseline] (168.263 ms) : 0, 168263
AppSec [candidate] (169.161 ms) : 0, 169161
Debugger [baseline] (66.698 ms) : 0, 66698
Debugger [candidate] (67.843 ms) : 0, 67843
Remote Config [baseline] (646.066 µs) : 0, 646
Remote Config [candidate] (663.75 µs) : 0, 664
Telemetry [baseline] (9.577 ms) : 0, 9577
Telemetry [candidate] (9.85 ms) : 0, 9850
Flare Poller [baseline] (3.769 ms) : 0, 3769
Flare Poller [candidate] (3.831 ms) : 0, 3831
IAST [baseline] (25.196 ms) : 0, 25196
IAST [candidate] (25.401 ms) : 0, 25401
section iast
crashtracking [baseline] (1.185 ms) : 0, 1185
crashtracking [candidate] (1.177 ms) : 0, 1177
BytebuddyAgent [baseline] (798.994 ms) : 0, 798994
BytebuddyAgent [candidate] (795.969 ms) : 0, 795969
AgentMeter [baseline] (11.342 ms) : 0, 11342
AgentMeter [candidate] (11.275 ms) : 0, 11275
GlobalTracer [baseline] (250.16 ms) : 0, 250160
GlobalTracer [candidate] (249.159 ms) : 0, 249159
AppSec [baseline] (32.409 ms) : 0, 32409
AppSec [candidate] (34.0 ms) : 0, 34000
Debugger [baseline] (69.185 ms) : 0, 69185
Debugger [candidate] (66.666 ms) : 0, 66666
Remote Config [baseline] (538.431 µs) : 0, 538
Remote Config [candidate] (533.309 µs) : 0, 533
Telemetry [baseline] (8.698 ms) : 0, 8698
Telemetry [candidate] (8.698 ms) : 0, 8698
Flare Poller [baseline] (3.527 ms) : 0, 3527
Flare Poller [candidate] (3.516 ms) : 0, 3516
IAST [baseline] (27.133 ms) : 0, 27133
IAST [candidate] (27.108 ms) : 0, 27108
section profiling
crashtracking [baseline] (1.226 ms) : 0, 1226
crashtracking [candidate] (1.21 ms) : 0, 1210
BytebuddyAgent [baseline] (683.325 ms) : 0, 683325
BytebuddyAgent [candidate] (682.356 ms) : 0, 682356
AgentMeter [baseline] (8.684 ms) : 0, 8684
AgentMeter [candidate] (8.629 ms) : 0, 8629
GlobalTracer [baseline] (216.473 ms) : 0, 216473
GlobalTracer [candidate] (216.224 ms) : 0, 216224
AppSec [baseline] (32.641 ms) : 0, 32641
AppSec [candidate] (32.605 ms) : 0, 32605
Debugger [baseline] (67.799 ms) : 0, 67799
Debugger [candidate] (67.683 ms) : 0, 67683
Remote Config [baseline] (629.863 µs) : 0, 630
Remote Config [candidate] (634.362 µs) : 0, 634
Telemetry [baseline] (8.914 ms) : 0, 8914
Telemetry [candidate] (9.008 ms) : 0, 9008
Flare Poller [baseline] (3.76 ms) : 0, 3760
Flare Poller [candidate] (3.796 ms) : 0, 3796
ProfilingAgent [baseline] (99.201 ms) : 0, 99201
ProfilingAgent [candidate] (99.518 ms) : 0, 99518
Profiling [baseline] (99.788 ms) : 0, 99788
Profiling [candidate] (100.091 ms) : 0, 100091
LoadParameters
See matching parameters
SummaryFound 4 performance improvements and 2 performance regressions! Performance is the same for 15 metrics, 15 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.60.0-SNAPSHOT~7fc80d49ab, baseline=1.60.0-SNAPSHOT~f215026f2d
dateFormat X
axisFormat %s
section baseline
no_agent (1.18 ms) : 1169, 1192
. : milestone, 1180,
iast (3.278 ms) : 3235, 3320
. : milestone, 3278,
iast_FULL (5.776 ms) : 5719, 5833
. : milestone, 5776,
iast_GLOBAL (3.654 ms) : 3598, 3711
. : milestone, 3654,
profiling (2.081 ms) : 2063, 2100
. : milestone, 2081,
tracing (1.769 ms) : 1753, 1784
. : milestone, 1769,
section candidate
no_agent (1.169 ms) : 1158, 1180
. : milestone, 1169,
iast (3.301 ms) : 3256, 3346
. : milestone, 3301,
iast_FULL (5.828 ms) : 5769, 5887
. : milestone, 5828,
iast_GLOBAL (3.562 ms) : 3502, 3621
. : milestone, 3562,
profiling (1.981 ms) : 1962, 1999
. : milestone, 1981,
tracing (1.819 ms) : 1803, 1835
. : milestone, 1819,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.60.0-SNAPSHOT~7fc80d49ab, baseline=1.60.0-SNAPSHOT~f215026f2d
dateFormat X
axisFormat %s
section baseline
no_agent (18.145 ms) : 17959, 18330
. : milestone, 18145,
appsec (18.669 ms) : 18484, 18855
. : milestone, 18669,
code_origins (17.69 ms) : 17515, 17866
. : milestone, 17690,
iast (17.332 ms) : 17162, 17503
. : milestone, 17332,
profiling (19.496 ms) : 19301, 19691
. : milestone, 19496,
tracing (17.51 ms) : 17335, 17685
. : milestone, 17510,
section candidate
no_agent (16.815 ms) : 16648, 16981
. : milestone, 16815,
appsec (18.644 ms) : 18455, 18834
. : milestone, 18644,
code_origins (17.607 ms) : 17433, 17781
. : milestone, 17607,
iast (18.515 ms) : 18324, 18706
. : milestone, 18515,
profiling (18.438 ms) : 18255, 18622
. : milestone, 18438,
tracing (17.577 ms) : 17401, 17752
. : milestone, 17577,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.60.0-SNAPSHOT~7fc80d49ab, baseline=1.60.0-SNAPSHOT~f215026f2d
dateFormat X
axisFormat %s
section baseline
no_agent (14.758 s) : 14758000, 14758000
. : milestone, 14758000,
appsec (14.786 s) : 14786000, 14786000
. : milestone, 14786000,
iast (17.782 s) : 17782000, 17782000
. : milestone, 17782000,
iast_GLOBAL (17.946 s) : 17946000, 17946000
. : milestone, 17946000,
profiling (14.849 s) : 14849000, 14849000
. : milestone, 14849000,
tracing (14.891 s) : 14891000, 14891000
. : milestone, 14891000,
section candidate
no_agent (15.057 s) : 15057000, 15057000
. : milestone, 15057000,
appsec (14.514 s) : 14514000, 14514000
. : milestone, 14514000,
iast (17.938 s) : 17938000, 17938000
. : milestone, 17938000,
iast_GLOBAL (17.974 s) : 17974000, 17974000
. : milestone, 17974000,
profiling (14.975 s) : 14975000, 14975000
. : milestone, 14975000,
tracing (14.814 s) : 14814000, 14814000
. : milestone, 14814000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.60.0-SNAPSHOT~7fc80d49ab, baseline=1.60.0-SNAPSHOT~f215026f2d
dateFormat X
axisFormat %s
section baseline
no_agent (1.469 ms) : 1458, 1481
. : milestone, 1469,
appsec (3.789 ms) : 3568, 4010
. : milestone, 3789,
iast (2.242 ms) : 2173, 2311
. : milestone, 2242,
iast_GLOBAL (2.291 ms) : 2222, 2361
. : milestone, 2291,
profiling (2.072 ms) : 2018, 2127
. : milestone, 2072,
tracing (2.058 ms) : 2005, 2111
. : milestone, 2058,
section candidate
no_agent (1.47 ms) : 1459, 1482
. : milestone, 1470,
appsec (3.788 ms) : 3566, 4010
. : milestone, 3788,
iast (2.245 ms) : 2176, 2314
. : milestone, 2245,
iast_GLOBAL (2.287 ms) : 2218, 2356
. : milestone, 2287,
profiling (2.1 ms) : 2043, 2156
. : milestone, 2100,
tracing (2.059 ms) : 2006, 2113
. : milestone, 2059,
|
fb53508 to
d710edb
Compare
d710edb to
9f37986
Compare
.github/chainguard/self.enforce-datadog-merge-queue.comment-pr.sts.yaml
Outdated
Show resolved
Hide resolved
| @@ -0,0 +1,11 @@ | |||
| issuer: https://token.actions.githubusercontent.com | |||
|
|
|||
| subject: repo:DataDog/dd-trace-java:ref:refs/heads/master | |||
There was a problem hiding this comment.
This may need to be more broad because the workflow is running for PRs, not from master..?
There was a problem hiding this comment.
Like subject: repo:DataDog/dd-trace-java:* from: https://docs.github.com/en/actions/reference/security/oidc#filtering-for-pull_request-events
There was a problem hiding this comment.
Yes, I was unsure about this one... I saw the :pull_request one but it was unclear if it refers the trigger or the workflow.
If it refers to the trigger, I don’t think I will ever need refs/head/master, so should I use :pull_request only?
There was a problem hiding this comment.
should I use :pull_request only?
Seems worth a try!
|
I'm merging it early so people will get them as soon as possible so I can enable this new PR check (even if it always pass for now). |
What Does This Do
This PR adds a workflow that will prevent GitHub merge queue to pass, and comment to trigger the Datadog merge queue instead.
Motivation
We would like to enable GitHub merge queue to prevent pull requests to be merge without merge queue.
But any protection rule will make the PR non eligible to the Datadog merge queue.
Additional Notes
I don't think the bot will be able to trigger the merge (it might not have the permission) but let's try it anyway.
For now, this check is not required but it will be when we enable GitHub merge queue.
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]
Note: Once your PR is ready to merge, add it to the merge queue by commenting
/merge./merge -ccancels the queue request./merge -f --reason "reason"skips all merge queue checks; please use this judiciously, as some checks do not run at the PR-level. For more information, see this doc.