Implement early exit for retry mechanisms#10604
Draft
daniel-mohedano wants to merge 3 commits intomasterfrom
Draft
Implement early exit for retry mechanisms#10604daniel-mohedano wants to merge 3 commits intomasterfrom
daniel-mohedano wants to merge 3 commits intomasterfrom
Conversation
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 62 metrics, 9 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.60.0-SNAPSHOT~7cec3c30a8, baseline=1.60.0-SNAPSHOT~2ebc964340
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.063 s) : 0, 1062543
Total [baseline] (10.908 s) : 0, 10908294
Agent [candidate] (1.064 s) : 0, 1064120
Total [candidate] (10.933 s) : 0, 10932574
section appsec
Agent [baseline] (1.235 s) : 0, 1234904
Total [baseline] (11.114 s) : 0, 11114403
Agent [candidate] (1.237 s) : 0, 1237122
Total [candidate] (11.119 s) : 0, 11119420
section iast
Agent [baseline] (1.231 s) : 0, 1230601
Total [baseline] (11.195 s) : 0, 11194949
Agent [candidate] (1.232 s) : 0, 1232317
Total [candidate] (11.249 s) : 0, 11248896
section profiling
Agent [baseline] (1.192 s) : 0, 1192058
Total [baseline] (10.998 s) : 0, 10997647
Agent [candidate] (1.191 s) : 0, 1190791
Total [candidate] (10.838 s) : 0, 10838471
gantt
title petclinic - break down per module: candidate=1.60.0-SNAPSHOT~7cec3c30a8, baseline=1.60.0-SNAPSHOT~2ebc964340
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.172 ms) : 0, 1172
crashtracking [candidate] (1.171 ms) : 0, 1171
BytebuddyAgent [baseline] (626.891 ms) : 0, 626891
BytebuddyAgent [candidate] (628.22 ms) : 0, 628220
AgentMeter [baseline] (28.812 ms) : 0, 28812
AgentMeter [candidate] (28.876 ms) : 0, 28876
GlobalTracer [baseline] (257.062 ms) : 0, 257062
GlobalTracer [candidate] (257.131 ms) : 0, 257131
AppSec [baseline] (32.658 ms) : 0, 32658
AppSec [candidate] (32.862 ms) : 0, 32862
Debugger [baseline] (65.714 ms) : 0, 65714
Debugger [candidate] (64.03 ms) : 0, 64030
Remote Config [baseline] (605.538 µs) : 0, 606
Remote Config [candidate] (608.552 µs) : 0, 609
Telemetry [baseline] (9.847 ms) : 0, 9847
Telemetry [candidate] (11.45 ms) : 0, 11450
Flare Poller [baseline] (4.576 ms) : 0, 4576
Flare Poller [candidate] (4.588 ms) : 0, 4588
section appsec
crashtracking [baseline] (1.188 ms) : 0, 1188
crashtracking [candidate] (1.174 ms) : 0, 1174
BytebuddyAgent [baseline] (655.585 ms) : 0, 655585
BytebuddyAgent [candidate] (657.179 ms) : 0, 657179
AgentMeter [baseline] (11.941 ms) : 0, 11941
AgentMeter [candidate] (11.942 ms) : 0, 11942
GlobalTracer [baseline] (257.446 ms) : 0, 257446
GlobalTracer [candidate] (257.742 ms) : 0, 257742
AppSec [baseline] (167.598 ms) : 0, 167598
AppSec [candidate] (167.91 ms) : 0, 167910
Debugger [baseline] (67.008 ms) : 0, 67008
Debugger [candidate] (66.981 ms) : 0, 66981
Remote Config [baseline] (653.886 µs) : 0, 654
Remote Config [candidate] (653.877 µs) : 0, 654
Telemetry [baseline] (9.497 ms) : 0, 9497
Telemetry [candidate] (9.493 ms) : 0, 9493
Flare Poller [baseline] (3.647 ms) : 0, 3647
Flare Poller [candidate] (3.687 ms) : 0, 3687
IAST [baseline] (25.069 ms) : 0, 25069
IAST [candidate] (25.115 ms) : 0, 25115
section iast
crashtracking [baseline] (1.177 ms) : 0, 1177
crashtracking [candidate] (1.172 ms) : 0, 1172
BytebuddyAgent [baseline] (795.463 ms) : 0, 795463
BytebuddyAgent [candidate] (795.913 ms) : 0, 795913
AgentMeter [baseline] (11.246 ms) : 0, 11246
AgentMeter [candidate] (11.221 ms) : 0, 11221
GlobalTracer [baseline] (247.893 ms) : 0, 247893
GlobalTracer [candidate] (248.479 ms) : 0, 248479
AppSec [baseline] (33.783 ms) : 0, 33783
AppSec [candidate] (33.178 ms) : 0, 33178
Debugger [baseline] (66.467 ms) : 0, 66467
Debugger [candidate] (67.628 ms) : 0, 67628
Remote Config [baseline] (539.301 µs) : 0, 539
Remote Config [candidate] (539.996 µs) : 0, 540
Telemetry [baseline] (8.531 ms) : 0, 8531
Telemetry [candidate] (8.587 ms) : 0, 8587
Flare Poller [baseline] (3.451 ms) : 0, 3451
Flare Poller [candidate] (3.481 ms) : 0, 3481
IAST [baseline] (26.836 ms) : 0, 26836
IAST [candidate] (26.875 ms) : 0, 26875
section profiling
ProfilingAgent [baseline] (99.537 ms) : 0, 99537
ProfilingAgent [candidate] (99.227 ms) : 0, 99227
crashtracking [baseline] (1.226 ms) : 0, 1226
crashtracking [candidate] (1.205 ms) : 0, 1205
BytebuddyAgent [baseline] (683.145 ms) : 0, 683145
BytebuddyAgent [candidate] (682.533 ms) : 0, 682533
AgentMeter [baseline] (8.638 ms) : 0, 8638
AgentMeter [candidate] (8.62 ms) : 0, 8620
GlobalTracer [baseline] (216.148 ms) : 0, 216148
GlobalTracer [candidate] (216.212 ms) : 0, 216212
AppSec [baseline] (32.733 ms) : 0, 32733
AppSec [candidate] (32.461 ms) : 0, 32461
Debugger [baseline] (67.468 ms) : 0, 67468
Debugger [candidate] (67.345 ms) : 0, 67345
Remote Config [baseline] (618.519 µs) : 0, 619
Remote Config [candidate] (621.329 µs) : 0, 621
Telemetry [baseline] (8.912 ms) : 0, 8912
Telemetry [candidate] (8.912 ms) : 0, 8912
Flare Poller [baseline] (3.755 ms) : 0, 3755
Flare Poller [candidate] (3.73 ms) : 0, 3730
Profiling [baseline] (100.102 ms) : 0, 100102
Profiling [candidate] (99.798 ms) : 0, 99798
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.60.0-SNAPSHOT~7cec3c30a8, baseline=1.60.0-SNAPSHOT~2ebc964340
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.064 s) : 0, 1063885
Total [baseline] (8.742 s) : 0, 8742117
Agent [candidate] (1.064 s) : 0, 1064003
Total [candidate] (8.73 s) : 0, 8729934
section iast
Agent [baseline] (1.231 s) : 0, 1230870
Total [baseline] (9.363 s) : 0, 9362899
Agent [candidate] (1.23 s) : 0, 1229520
Total [candidate] (9.361 s) : 0, 9360638
gantt
title insecure-bank - break down per module: candidate=1.60.0-SNAPSHOT~7cec3c30a8, baseline=1.60.0-SNAPSHOT~2ebc964340
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.181 ms) : 0, 1181
crashtracking [candidate] (1.181 ms) : 0, 1181
BytebuddyAgent [baseline] (629.084 ms) : 0, 629084
BytebuddyAgent [candidate] (628.583 ms) : 0, 628583
AgentMeter [baseline] (28.908 ms) : 0, 28908
AgentMeter [candidate] (29.032 ms) : 0, 29032
GlobalTracer [baseline] (257.776 ms) : 0, 257776
GlobalTracer [candidate] (257.299 ms) : 0, 257299
AppSec [baseline] (32.828 ms) : 0, 32828
AppSec [candidate] (32.748 ms) : 0, 32748
Debugger [baseline] (60.552 ms) : 0, 60552
Debugger [candidate] (61.825 ms) : 0, 61825
Remote Config [baseline] (642.336 µs) : 0, 642
Remote Config [candidate] (617.242 µs) : 0, 617
Telemetry [baseline] (11.454 ms) : 0, 11454
Telemetry [candidate] (12.89 ms) : 0, 12890
Flare Poller [baseline] (6.121 ms) : 0, 6121
Flare Poller [candidate] (4.557 ms) : 0, 4557
section iast
crashtracking [baseline] (1.176 ms) : 0, 1176
crashtracking [candidate] (1.197 ms) : 0, 1197
BytebuddyAgent [baseline] (795.456 ms) : 0, 795456
BytebuddyAgent [candidate] (794.977 ms) : 0, 794977
AgentMeter [baseline] (11.264 ms) : 0, 11264
AgentMeter [candidate] (11.261 ms) : 0, 11261
GlobalTracer [baseline] (248.373 ms) : 0, 248373
GlobalTracer [candidate] (247.929 ms) : 0, 247929
AppSec [baseline] (33.251 ms) : 0, 33251
AppSec [candidate] (33.776 ms) : 0, 33776
Debugger [baseline] (66.491 ms) : 0, 66491
Debugger [candidate] (65.777 ms) : 0, 65777
Remote Config [baseline] (528.788 µs) : 0, 529
Remote Config [candidate] (533.602 µs) : 0, 534
Telemetry [baseline] (8.621 ms) : 0, 8621
Telemetry [candidate] (8.628 ms) : 0, 8628
Flare Poller [baseline] (3.497 ms) : 0, 3497
Flare Poller [candidate] (3.466 ms) : 0, 3466
IAST [baseline] (26.948 ms) : 0, 26948
IAST [candidate] (26.788 ms) : 0, 26788
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 3 performance regressions! Performance is the same for 17 metrics, 15 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.60.0-SNAPSHOT~7cec3c30a8, baseline=1.60.0-SNAPSHOT~2ebc964340
dateFormat X
axisFormat %s
section baseline
no_agent (17.78 ms) : 17602, 17958
. : milestone, 17780,
appsec (18.399 ms) : 18210, 18587
. : milestone, 18399,
code_origins (17.654 ms) : 17477, 17830
. : milestone, 17654,
iast (18.198 ms) : 18018, 18379
. : milestone, 18198,
profiling (18.409 ms) : 18226, 18593
. : milestone, 18409,
tracing (17.675 ms) : 17499, 17850
. : milestone, 17675,
section candidate
no_agent (19.237 ms) : 19036, 19438
. : milestone, 19237,
appsec (18.714 ms) : 18527, 18901
. : milestone, 18714,
code_origins (17.705 ms) : 17529, 17881
. : milestone, 17705,
iast (17.734 ms) : 17557, 17910
. : milestone, 17734,
profiling (18.664 ms) : 18473, 18854
. : milestone, 18664,
tracing (17.7 ms) : 17521, 17878
. : milestone, 17700,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.60.0-SNAPSHOT~7cec3c30a8, baseline=1.60.0-SNAPSHOT~2ebc964340
dateFormat X
axisFormat %s
section baseline
no_agent (1.182 ms) : 1171, 1193
. : milestone, 1182,
iast (3.038 ms) : 3000, 3077
. : milestone, 3038,
iast_FULL (5.835 ms) : 5777, 5893
. : milestone, 5835,
iast_GLOBAL (3.534 ms) : 3475, 3594
. : milestone, 3534,
profiling (2.097 ms) : 2076, 2118
. : milestone, 2097,
tracing (1.789 ms) : 1774, 1805
. : milestone, 1789,
section candidate
no_agent (1.178 ms) : 1167, 1190
. : milestone, 1178,
iast (3.198 ms) : 3153, 3244
. : milestone, 3198,
iast_FULL (5.789 ms) : 5731, 5847
. : milestone, 5789,
iast_GLOBAL (3.396 ms) : 3344, 3448
. : milestone, 3396,
profiling (2.125 ms) : 2106, 2144
. : milestone, 2125,
tracing (1.754 ms) : 1740, 1768
. : milestone, 1754,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.60.0-SNAPSHOT~7cec3c30a8, baseline=1.60.0-SNAPSHOT~2ebc964340
dateFormat X
axisFormat %s
section baseline
no_agent (1.482 ms) : 1471, 1494
. : milestone, 1482,
appsec (3.745 ms) : 3526, 3964
. : milestone, 3745,
iast (2.257 ms) : 2187, 2326
. : milestone, 2257,
iast_GLOBAL (2.305 ms) : 2235, 2375
. : milestone, 2305,
profiling (2.119 ms) : 2062, 2175
. : milestone, 2119,
tracing (2.087 ms) : 2033, 2141
. : milestone, 2087,
section candidate
no_agent (1.482 ms) : 1470, 1494
. : milestone, 1482,
appsec (3.853 ms) : 3628, 4077
. : milestone, 3853,
iast (2.273 ms) : 2204, 2343
. : milestone, 2273,
iast_GLOBAL (2.311 ms) : 2241, 2381
. : milestone, 2311,
profiling (2.115 ms) : 2058, 2171
. : milestone, 2115,
tracing (2.082 ms) : 2028, 2136
. : milestone, 2082,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.60.0-SNAPSHOT~7cec3c30a8, baseline=1.60.0-SNAPSHOT~2ebc964340
dateFormat X
axisFormat %s
section baseline
no_agent (15.341 s) : 15341000, 15341000
. : milestone, 15341000,
appsec (14.936 s) : 14936000, 14936000
. : milestone, 14936000,
iast (18.136 s) : 18136000, 18136000
. : milestone, 18136000,
iast_GLOBAL (17.729 s) : 17729000, 17729000
. : milestone, 17729000,
profiling (14.985 s) : 14985000, 14985000
. : milestone, 14985000,
tracing (14.754 s) : 14754000, 14754000
. : milestone, 14754000,
section candidate
no_agent (15.661 s) : 15661000, 15661000
. : milestone, 15661000,
appsec (14.928 s) : 14928000, 14928000
. : milestone, 14928000,
iast (18.394 s) : 18394000, 18394000
. : milestone, 18394000,
iast_GLOBAL (17.73 s) : 17730000, 17730000
. : milestone, 17730000,
profiling (14.861 s) : 14861000, 14861000
. : milestone, 14861000,
tracing (15.037 s) : 15037000, 15037000
. : milestone, 15037000,
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
Motivation
Additional Notes
test-environment-trigger: skip
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]
Note: Once your PR is ready to merge, add it to the merge queue by commenting
/merge./merge -ccancels the queue request./merge -f --reason "reason"skips all merge queue checks; please use this judiciously, as some checks do not run at the PR-level. For more information, see this doc.