Conversation
|
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
Kafka / producer-benchmarkParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 3 metrics, 0 unstable metrics. See unchanged results
|
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 64 metrics, 7 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.60.0-SNAPSHOT~791045757c, baseline=1.60.0-SNAPSHOT~405276aea3
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.067 s) : 0, 1066953
Total [baseline] (10.92 s) : 0, 10919997
Agent [candidate] (1.068 s) : 0, 1068245
Total [candidate] (10.78 s) : 0, 10780123
section appsec
Agent [baseline] (1.239 s) : 0, 1239101
Total [baseline] (11.025 s) : 0, 11025077
Agent [candidate] (1.24 s) : 0, 1239769
Total [candidate] (11.039 s) : 0, 11039340
section iast
Agent [baseline] (1.242 s) : 0, 1242368
Total [baseline] (11.099 s) : 0, 11099185
Agent [candidate] (1.233 s) : 0, 1232724
Total [candidate] (11.178 s) : 0, 11178155
section profiling
Agent [baseline] (1.19 s) : 0, 1190379
Total [baseline] (10.981 s) : 0, 10981125
Agent [candidate] (1.197 s) : 0, 1196970
Total [candidate] (11.015 s) : 0, 11015393
gantt
title petclinic - break down per module: candidate=1.60.0-SNAPSHOT~791045757c, baseline=1.60.0-SNAPSHOT~405276aea3
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.178 ms) : 0, 1178
crashtracking [candidate] (1.182 ms) : 0, 1182
BytebuddyAgent [baseline] (630.016 ms) : 0, 630016
BytebuddyAgent [candidate] (630.326 ms) : 0, 630326
AgentMeter [baseline] (29.03 ms) : 0, 29030
AgentMeter [candidate] (28.919 ms) : 0, 28919
GlobalTracer [baseline] (257.975 ms) : 0, 257975
GlobalTracer [candidate] (258.117 ms) : 0, 258117
AppSec [baseline] (32.871 ms) : 0, 32871
AppSec [candidate] (32.789 ms) : 0, 32789
Debugger [baseline] (63.744 ms) : 0, 63744
Debugger [candidate] (61.747 ms) : 0, 61747
Remote Config [baseline] (612.135 µs) : 0, 612
Remote Config [candidate] (646.959 µs) : 0, 647
Telemetry [baseline] (10.708 ms) : 0, 10708
Telemetry [candidate] (13.034 ms) : 0, 13034
Flare Poller [baseline] (5.413 ms) : 0, 5413
Flare Poller [candidate] (6.167 ms) : 0, 6167
section appsec
crashtracking [baseline] (1.174 ms) : 0, 1174
crashtracking [candidate] (1.174 ms) : 0, 1174
BytebuddyAgent [baseline] (658.31 ms) : 0, 658310
BytebuddyAgent [candidate] (658.465 ms) : 0, 658465
AgentMeter [baseline] (11.967 ms) : 0, 11967
AgentMeter [candidate] (11.954 ms) : 0, 11954
GlobalTracer [baseline] (257.907 ms) : 0, 257907
GlobalTracer [candidate] (258.205 ms) : 0, 258205
AppSec [baseline] (167.696 ms) : 0, 167696
AppSec [candidate] (168.022 ms) : 0, 168022
Debugger [baseline] (67.233 ms) : 0, 67233
Debugger [candidate] (67.343 ms) : 0, 67343
Remote Config [baseline] (672.019 µs) : 0, 672
Remote Config [candidate] (667.769 µs) : 0, 668
Telemetry [baseline] (9.765 ms) : 0, 9765
Telemetry [candidate] (9.693 ms) : 0, 9693
Flare Poller [baseline] (3.78 ms) : 0, 3780
Flare Poller [candidate] (3.71 ms) : 0, 3710
IAST [baseline] (25.332 ms) : 0, 25332
IAST [candidate] (25.244 ms) : 0, 25244
section iast
crashtracking [baseline] (1.183 ms) : 0, 1183
crashtracking [candidate] (1.191 ms) : 0, 1191
BytebuddyAgent [baseline] (803.187 ms) : 0, 803187
BytebuddyAgent [candidate] (796.319 ms) : 0, 796319
AgentMeter [baseline] (11.559 ms) : 0, 11559
AgentMeter [candidate] (11.276 ms) : 0, 11276
GlobalTracer [baseline] (249.677 ms) : 0, 249677
GlobalTracer [candidate] (248.273 ms) : 0, 248273
AppSec [baseline] (34.775 ms) : 0, 34775
AppSec [candidate] (32.959 ms) : 0, 32959
Debugger [baseline] (66.893 ms) : 0, 66893
Debugger [candidate] (67.93 ms) : 0, 67930
Remote Config [baseline] (545.627 µs) : 0, 546
Remote Config [candidate] (531.806 µs) : 0, 532
Telemetry [baseline] (8.574 ms) : 0, 8574
Telemetry [candidate] (8.548 ms) : 0, 8548
Flare Poller [baseline] (3.487 ms) : 0, 3487
Flare Poller [candidate] (3.429 ms) : 0, 3429
IAST [baseline] (27.106 ms) : 0, 27106
IAST [candidate] (27.036 ms) : 0, 27036
section profiling
ProfilingAgent [baseline] (99.194 ms) : 0, 99194
ProfilingAgent [candidate] (99.033 ms) : 0, 99033
crashtracking [baseline] (1.248 ms) : 0, 1248
crashtracking [candidate] (1.231 ms) : 0, 1231
BytebuddyAgent [baseline] (682.282 ms) : 0, 682282
BytebuddyAgent [candidate] (686.749 ms) : 0, 686749
AgentMeter [baseline] (8.654 ms) : 0, 8654
AgentMeter [candidate] (8.628 ms) : 0, 8628
GlobalTracer [baseline] (215.697 ms) : 0, 215697
GlobalTracer [candidate] (217.159 ms) : 0, 217159
AppSec [baseline] (32.588 ms) : 0, 32588
AppSec [candidate] (33.008 ms) : 0, 33008
Debugger [baseline] (67.4 ms) : 0, 67400
Debugger [candidate] (67.75 ms) : 0, 67750
Remote Config [baseline] (629.506 µs) : 0, 630
Remote Config [candidate] (623.432 µs) : 0, 623
Telemetry [baseline] (8.96 ms) : 0, 8960
Telemetry [candidate] (8.917 ms) : 0, 8917
Flare Poller [baseline] (3.734 ms) : 0, 3734
Flare Poller [candidate] (3.722 ms) : 0, 3722
Profiling [baseline] (99.761 ms) : 0, 99761
Profiling [candidate] (99.614 ms) : 0, 99614
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.60.0-SNAPSHOT~791045757c, baseline=1.60.0-SNAPSHOT~405276aea3
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.064 s) : 0, 1063923
Total [baseline] (8.746 s) : 0, 8746039
Agent [candidate] (1.065 s) : 0, 1064757
Total [candidate] (8.748 s) : 0, 8747510
section iast
Agent [baseline] (1.241 s) : 0, 1240879
Total [baseline] (9.378 s) : 0, 9378390
Agent [candidate] (1.234 s) : 0, 1233880
Total [candidate] (9.336 s) : 0, 9336270
gantt
title insecure-bank - break down per module: candidate=1.60.0-SNAPSHOT~791045757c, baseline=1.60.0-SNAPSHOT~405276aea3
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.186 ms) : 0, 1186
crashtracking [candidate] (1.186 ms) : 0, 1186
BytebuddyAgent [baseline] (628.51 ms) : 0, 628510
BytebuddyAgent [candidate] (628.487 ms) : 0, 628487
AgentMeter [baseline] (29.036 ms) : 0, 29036
AgentMeter [candidate] (28.843 ms) : 0, 28843
GlobalTracer [baseline] (256.986 ms) : 0, 256986
GlobalTracer [candidate] (257.74 ms) : 0, 257740
AppSec [baseline] (32.611 ms) : 0, 32611
AppSec [candidate] (32.768 ms) : 0, 32768
Debugger [baseline] (59.706 ms) : 0, 59706
Debugger [candidate] (60.61 ms) : 0, 60610
Remote Config [baseline] (641.778 µs) : 0, 642
Remote Config [candidate] (630.85 µs) : 0, 631
Telemetry [baseline] (13.774 ms) : 0, 13774
Telemetry [candidate] (14.564 ms) : 0, 14564
Flare Poller [baseline] (6.106 ms) : 0, 6106
Flare Poller [candidate] (4.641 ms) : 0, 4641
section iast
crashtracking [baseline] (1.183 ms) : 0, 1183
crashtracking [candidate] (1.173 ms) : 0, 1173
BytebuddyAgent [baseline] (803.195 ms) : 0, 803195
BytebuddyAgent [candidate] (797.981 ms) : 0, 797981
AgentMeter [baseline] (11.58 ms) : 0, 11580
AgentMeter [candidate] (11.272 ms) : 0, 11272
GlobalTracer [baseline] (249.337 ms) : 0, 249337
GlobalTracer [candidate] (248.8 ms) : 0, 248800
IAST [baseline] (27.329 ms) : 0, 27329
IAST [candidate] (27.027 ms) : 0, 27027
AppSec [baseline] (35.824 ms) : 0, 35824
AppSec [candidate] (35.04 ms) : 0, 35040
Debugger [baseline] (64.15 ms) : 0, 64150
Debugger [candidate] (64.776 ms) : 0, 64776
Remote Config [baseline] (532.635 µs) : 0, 533
Remote Config [candidate] (536.607 µs) : 0, 537
Telemetry [baseline] (8.716 ms) : 0, 8716
Telemetry [candidate] (8.625 ms) : 0, 8625
Flare Poller [baseline] (3.572 ms) : 0, 3572
Flare Poller [candidate] (3.41 ms) : 0, 3410
LoadParameters
See matching parameters
SummaryFound 3 performance improvements and 0 performance regressions! Performance is the same for 17 metrics, 16 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.60.0-SNAPSHOT~791045757c, baseline=1.60.0-SNAPSHOT~405276aea3
dateFormat X
axisFormat %s
section baseline
no_agent (18.357 ms) : 18167, 18546
. : milestone, 18357,
appsec (19.1 ms) : 18908, 19292
. : milestone, 19100,
code_origins (17.56 ms) : 17385, 17734
. : milestone, 17560,
iast (17.654 ms) : 17477, 17832
. : milestone, 17654,
profiling (18.608 ms) : 18421, 18794
. : milestone, 18608,
tracing (17.687 ms) : 17512, 17862
. : milestone, 17687,
section candidate
no_agent (19.208 ms) : 19010, 19405
. : milestone, 19208,
appsec (18.604 ms) : 18415, 18794
. : milestone, 18604,
code_origins (17.617 ms) : 17443, 17792
. : milestone, 17617,
iast (17.571 ms) : 17395, 17748
. : milestone, 17571,
profiling (18.466 ms) : 18284, 18649
. : milestone, 18466,
tracing (17.704 ms) : 17528, 17880
. : milestone, 17704,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.60.0-SNAPSHOT~791045757c, baseline=1.60.0-SNAPSHOT~405276aea3
dateFormat X
axisFormat %s
section baseline
no_agent (1.199 ms) : 1187, 1211
. : milestone, 1199,
iast (3.248 ms) : 3205, 3291
. : milestone, 3248,
iast_FULL (5.96 ms) : 5899, 6021
. : milestone, 5960,
iast_GLOBAL (3.612 ms) : 3551, 3673
. : milestone, 3612,
profiling (1.969 ms) : 1952, 1986
. : milestone, 1969,
tracing (1.789 ms) : 1774, 1803
. : milestone, 1789,
section candidate
no_agent (1.186 ms) : 1174, 1197
. : milestone, 1186,
iast (2.988 ms) : 2955, 3022
. : milestone, 2988,
iast_FULL (5.773 ms) : 5715, 5831
. : milestone, 5773,
iast_GLOBAL (3.446 ms) : 3390, 3502
. : milestone, 3446,
profiling (2.039 ms) : 2022, 2056
. : milestone, 2039,
tracing (1.803 ms) : 1788, 1818
. : milestone, 1803,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 2 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.60.0-SNAPSHOT~791045757c, baseline=1.60.0-SNAPSHOT~405276aea3
dateFormat X
axisFormat %s
section baseline
no_agent (1.48 ms) : 1468, 1491
. : milestone, 1480,
appsec (3.796 ms) : 3577, 4014
. : milestone, 3796,
iast (2.265 ms) : 2195, 2334
. : milestone, 2265,
iast_GLOBAL (2.315 ms) : 2245, 2384
. : milestone, 2315,
profiling (2.114 ms) : 2056, 2171
. : milestone, 2114,
tracing (2.077 ms) : 2024, 2131
. : milestone, 2077,
section candidate
no_agent (1.479 ms) : 1467, 1490
. : milestone, 1479,
appsec (3.8 ms) : 3577, 4023
. : milestone, 3800,
iast (2.268 ms) : 2198, 2338
. : milestone, 2268,
iast_GLOBAL (2.306 ms) : 2237, 2376
. : milestone, 2306,
profiling (2.516 ms) : 2352, 2680
. : milestone, 2516,
tracing (2.077 ms) : 2023, 2131
. : milestone, 2077,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.60.0-SNAPSHOT~791045757c, baseline=1.60.0-SNAPSHOT~405276aea3
dateFormat X
axisFormat %s
section baseline
no_agent (15.556 s) : 15556000, 15556000
. : milestone, 15556000,
appsec (14.826 s) : 14826000, 14826000
. : milestone, 14826000,
iast (18.075 s) : 18075000, 18075000
. : milestone, 18075000,
iast_GLOBAL (17.899 s) : 17899000, 17899000
. : milestone, 17899000,
profiling (14.868 s) : 14868000, 14868000
. : milestone, 14868000,
tracing (14.827 s) : 14827000, 14827000
. : milestone, 14827000,
section candidate
no_agent (14.928 s) : 14928000, 14928000
. : milestone, 14928000,
appsec (14.94 s) : 14940000, 14940000
. : milestone, 14940000,
iast (17.966 s) : 17966000, 17966000
. : milestone, 17966000,
iast_GLOBAL (17.8 s) : 17800000, 17800000
. : milestone, 17800000,
profiling (14.763 s) : 14763000, 14763000
. : milestone, 14763000,
tracing (14.959 s) : 14959000, 14959000
. : milestone, 14959000,
|
Kafka / consumer-benchmarkParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 3 metrics, 0 unstable metrics. See unchanged results
|
| span, | ||
| DataStreamsTransactionExtractor.Type.KAFKA_PRODUCE_HEADERS, | ||
| record, | ||
| record.headers(), |
There was a problem hiding this comment.
ok but I would protect rather this:
DSM_TRANSACTION_SOURCE_READER =
(source, headerName) -> new String(((Headers) source).lastHeader(headerName).value());
or better type the argument to prevent in the future this kind of issues
There was a problem hiding this comment.
added protective try/catch for all header readers to keep it simple for now.
| (source, headerName) -> { | ||
| try { | ||
| return getRequestHeader((REQUEST) source, headerName); | ||
| } catch (Exception e) { |
There was a problem hiding this comment.
| } catch (Exception e) { | |
| } catch (Throwable ignored) { |
What Does This Do
Fixes a bug when the record was passed to extractor instead of headers.
Motivation
Kafka Produce extractors currently fails with: