Skip to content

Saving buildGitInfo lambda into a member variable #10615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dougqh wants to merge 2 commits into
base: master
Choose a base branch
from
+5 −1
Open

Saving buildGitInfo lambda into a member variable #10615

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d9d7047
Saving buildGitInfo lambda into a member variable
dougqh Feb 17, 2026
f0560d1
spotless
dougqh Feb 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion internal-api/src/main/java/datadog/trace/api/git/GitInfoProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,10 @@ public class GitInfoProvider {
// in the same daemon is unlikely
private final DDCache<String, GitInfo> gitInfoCache = DDCaches.newFixedSizeCache(4);

// DQH - The lambda in getGitInfo was a hot allocation point, so
// pulled the lambda into a member variable to avoid constantly allocating.
final Function<String, GitInfo> buildGitInfoFn = this::buildGitInfo;

public GitInfo getGitInfo() {
return getGitInfo(null);
}
Expand All @@ -56,7 +60,7 @@ public GitInfo getGitInfo(@Nullable String repositoryPath) {
repositoryPath = NULL_PATH_STRING;
}

return gitInfoCache.computeIfAbsent(repositoryPath, this::buildGitInfo);
return gitInfoCache.computeIfAbsent(repositoryPath, buildGitInfoFn);
}

private GitInfo buildGitInfo(String repositoryPath) {
Expand Down