-
Notifications
You must be signed in to change notification settings - Fork 15
feat(profiling): File endpoint for exporter #1421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Artifact Size Benchmark Reportaarch64-alpine-linux-musl
aarch64-apple-darwin
aarch64-unknown-linux-gnu
libdatadog-x64-windows
libdatadog-x86-windows
x86_64-alpine-linux-musl
x86_64-apple-darwin
x86_64-unknown-linux-gnu
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1421 +/- ##
==========================================
+ Coverage 71.23% 71.38% +0.15%
==========================================
Files 411 413 +2
Lines 65788 66152 +364
==========================================
+ Hits 46863 47223 +360
- Misses 18925 18929 +4
🚀 New features to boost your workflow:
|
3e70843 to
2632ccf
Compare
BenchmarksComparisonBenchmark execution time: 2026-01-07 15:38:50 Comparing candidate commit 75e7cbd in PR branch Found 0 performance improvements and 22 performance regressions! Performance is the same for 35 metrics, 2 unstable metrics. scenario:benching serializing traces from their internal representation to msgpack
scenario:credit_card/is_card_number/ 3782-8224-6310-005
scenario:credit_card/is_card_number/ 378282246310005
scenario:credit_card/is_card_number/378282246310005
scenario:credit_card/is_card_number/37828224631000521389798
scenario:credit_card/is_card_number/x371413321323331
scenario:credit_card/is_card_number_no_luhn/ 3782-8224-6310-005
scenario:credit_card/is_card_number_no_luhn/ 378282246310005
scenario:credit_card/is_card_number_no_luhn/378282246310005
scenario:credit_card/is_card_number_no_luhn/37828224631000521389798
scenario:credit_card/is_card_number_no_luhn/x371413321323331
scenario:normalization/normalize_service/normalize_service/[empty string]
CandidateCandidate benchmark detailsGroup 1
Group 2
Group 3
Group 4
Group 5
Group 6
Group 7
Group 8
Group 9
Group 10
Group 11
Group 12
Group 13
Group 14
Group 15
Group 16
Group 17
Group 18
Group 19
BaselineOmitted due to size. |
8c22595 to
1b45afc
Compare
morrisonlevi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't finish reviewing but I had some questions.
1b45afc to
9f23822
Compare
9f23822 to
5b4076c
Compare
|
✅ Tests 🎉 All green!❄️ No new flaky tests detected 🔗 Commit SHA: 75e7cbd | Docs | Datadog PR Page | Was this helpful? Give us feedback! |
384daab to
a424236
Compare
cdf1dec to
0759666
Compare
31d6a70 to
51f264b
Compare
4266b30 to
53850e7
Compare
53850e7 to
75e7cbd
Compare
What does this PR do?
Adds a
file://endpoint to the profile exporter.Motivation
For testing and debugging purposes, its really useful to see exactly what bytes were sent. This is useful both within libdatadog, and also for any clients.
Additional Notes
Anything else we should know when reviewing?
How to test the change?
New integration tests in the PR.