Skip to content

Conversation

@natanieljr
Copy link

Dear Nikolaus,

In that commit I did the following changes:

  • Added a local Gradle instance (as recommended by the developers): Prevents conflicts and remove Gradle installation requirement
  • Put all classes in packages (at.unisalzburg.aapted.<old_package_names> to follow java standards
  • Added option do publish on mavenLocal (I haven’t uploaded to mavenCentral, but would be great), allowing it to be easily used in other Gradle/Maven projects (details on how to do it are on the readme file)

The main benefit of these changes is to improve easiness to use. Currently, to be used in another project, AAPTED JAR has to be copied to a folder and linked to the project as a dependency. With my change, once you deploy it locally, Gradle can handle the dependency management.

Regards,

Nataniel

@mateuszpawlik
Copy link
Collaborator

I've commented on the pull request #6. It also contains packaging changes. When we're done with it, I come back here.

@mateuszpawlik
Copy link
Collaborator

Please see the last changes in the master branch and let me know what would be still missing to fix. I think that's only the Maven part. Is that correct?

@natanieljr
Copy link
Author

Yes,

All that is missing is the maven plugin to deploy it to a local maven repository.

@mateuszpawlik
Copy link
Collaborator

We're discontinuing this repository. Is this pull request still interesting to resolve?

Have a look at our new C++ Tree Similarity library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants