Fix skipped jest tests #32385
Open
Fix skipped jest tests #32385
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…CardView-Fix-skipped-tests-26_1
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes skipped Jest tests by implementing missing functionality and removing obsolete test cases. The changes enable previously skipped tests to run by adding template handling support to the component mock and implementing actual test logic.
Changes:
- Added
_getTemplatemethod to component mock to handle function templates - Implemented test cases for editing buttons in CardView components
- Removed obsolete skipped tests that are no longer needed
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| component.mock.ts | Added _getTemplate method to support function template handling in tests |
| utils.test.ts | Removed skipped placeholder test for promises |
| options.test.ts | Implemented tests for edit/remove buttons and cleanup; removed obsolete editor state test |
| render.test.ts | Removed skipped accessibility status description test |
| header_panel/options.test.ts | Fixed template function signatures to access model.column instead of column directly |
| options.test.ts.snap | Added snapshots for newly implemented headerItemTemplate tests |
| ai_column.integration.test.ts | Removed skipped test for repaintChangesOnly functionality |
packages/devextreme/js/__internal/grids/new/card_view/header_panel/options.test.ts
Show resolved
Hide resolved
packages/devextreme/js/__internal/grids/new/card_view/header_panel/options.test.ts
Show resolved
Hide resolved
packages/devextreme/js/__internal/grids/new/grid_core/editing/options.test.ts
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.