Skip to content

Conversation

@mpreyskurantov
Copy link
Contributor

@mpreyskurantov mpreyskurantov commented Feb 4, 2026

…-angular/src/ui/nested/base/text-editor-button-dxi.ts via single rule, ref DevExpress#25395
@mpreyskurantov mpreyskurantov self-assigned this Feb 4, 2026
@mpreyskurantov mpreyskurantov requested a review from a team as a code owner February 4, 2026 17:20
@mpreyskurantov mpreyskurantov added the WIP Work in progress label Feb 4, 2026
@mpreyskurantov mpreyskurantov requested a review from a team as a code owner February 4, 2026 17:20
Copilot AI review requested due to automatic review settings February 4, 2026 17:20
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a dedicated ColumnButtonClickEvent API surface for TreeList column-button clicks and propagates that type through generated typings and wrappers to match DataGrid’s existing pattern.

Changes:

  • Documents ColumnButtonClickEvent in TreeList typings and adds row/column member doc links.
  • Updates TreeList column button onClick callback typing to use ColumnButtonClickEvent across core typings and React/Vue/Angular wrappers.
  • Removes the incorrect onClick exposure from the generic Angular text-editor dxi-button nested option base.

Reviewed changes

Copilot reviewed 7 out of 9 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
packages/devextreme/ts/dx.all.d.ts Adds documentation descriptors for ColumnButtonClickEvent and its members in the bundled declarations.
packages/devextreme/js/ui/tree_list.d.ts Introduces full doc metadata for ColumnButtonClickEvent and updates dxTreeListColumnButton.onClick param doc reference.
packages/devextreme-vue/src/tree-list.ts Aligns Vue wrapper onClick prop types for TreeList column buttons to ColumnButtonClickEvent.
packages/devextreme-react/src/tree-list.ts Aligns React wrapper onClick prop types for TreeList column buttons to ColumnButtonClickEvent.
packages/devextreme-metadata/make-angular-metadata.ts Adds a metadata mutation intended to remove ColumnButton.onClick members (risk: can affect generated Angular API).
packages/devextreme-angular/src/ui/tree-list/nested/column-button-dxi.ts Updates Angular TreeList column-button onClick typing to ColumnButtonClickEvent.
packages/devextreme-angular/src/ui/tree-list/nested/button-dxi.ts Updates Angular TreeList button onClick typing to ColumnButtonClickEvent.
packages/devextreme-angular/src/ui/nested/button-dxi.ts Removes onClick from generic dxi-button inputs (text editor button config).
packages/devextreme-angular/src/ui/nested/base/text-editor-button-dxi.ts Removes incorrect onClick accessor and unrelated ColumnButtonClickEvent import from the text-editor button base.

@mpreyskurantov mpreyskurantov changed the title WIP: TreeList ColumnButtonClickEvent TreeList - Column button does not accept ColumnButtonClickEvent as the onClick event type (T1319919) Feb 6, 2026
…T1319919

# Conflicts:
#	packages/devextreme-react/src/tree-list.ts
#	packages/devextreme-vue/src/tree-list.ts
Copilot AI review requested due to automatic review settings February 10, 2026 08:26
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 7 changed files in this pull request and generated 1 comment.

@mpreyskurantov mpreyskurantov removed the WIP Work in progress label Feb 10, 2026
@marker-dao
Copy link
Contributor

LGTM

@mpreyskurantov mpreyskurantov merged commit dc0d37e into DevExpress:26_1 Feb 11, 2026
133 of 136 checks passed
@mpreyskurantov mpreyskurantov deleted the 26_1-25395-T1319919 branch February 11, 2026 13:59
mpreyskurantov added a commit to mpreyskurantov/DevExtreme that referenced this pull request Feb 11, 2026
mpreyskurantov added a commit to mpreyskurantov/DevExtreme that referenced this pull request Feb 11, 2026
…e onClick event type (T1319919) (DevExpress#32404)

# Conflicts:
#	packages/devextreme-angular/src/ui/tree-list/nested/button-dxi.ts
#	packages/devextreme-angular/src/ui/tree-list/nested/column-button-dxi.ts
#	packages/devextreme-metadata/make-angular-metadata.ts
#	packages/devextreme-react/src/tree-list.ts
#	packages/devextreme-vue/src/tree-list.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants