-
Notifications
You must be signed in to change notification settings - Fork 667
TreeList - Column button does not accept ColumnButtonClickEvent as the onClick event type (T1319919) #32404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TreeList - Column button does not accept ColumnButtonClickEvent as the onClick event type (T1319919) #32404
Conversation
…lickEvent type in onClick prop
…-angular/src/ui/nested/base/text-editor-button-dxi.ts via single rule, ref DevExpress#25395
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Adds a dedicated ColumnButtonClickEvent API surface for TreeList column-button clicks and propagates that type through generated typings and wrappers to match DataGrid’s existing pattern.
Changes:
- Documents
ColumnButtonClickEventin TreeList typings and addsrow/columnmember doc links. - Updates TreeList column button
onClickcallback typing to useColumnButtonClickEventacross core typings and React/Vue/Angular wrappers. - Removes the incorrect
onClickexposure from the generic Angular text-editordxi-buttonnested option base.
Reviewed changes
Copilot reviewed 7 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packages/devextreme/ts/dx.all.d.ts | Adds documentation descriptors for ColumnButtonClickEvent and its members in the bundled declarations. |
| packages/devextreme/js/ui/tree_list.d.ts | Introduces full doc metadata for ColumnButtonClickEvent and updates dxTreeListColumnButton.onClick param doc reference. |
| packages/devextreme-vue/src/tree-list.ts | Aligns Vue wrapper onClick prop types for TreeList column buttons to ColumnButtonClickEvent. |
| packages/devextreme-react/src/tree-list.ts | Aligns React wrapper onClick prop types for TreeList column buttons to ColumnButtonClickEvent. |
| packages/devextreme-metadata/make-angular-metadata.ts | Adds a metadata mutation intended to remove ColumnButton.onClick members (risk: can affect generated Angular API). |
| packages/devextreme-angular/src/ui/tree-list/nested/column-button-dxi.ts | Updates Angular TreeList column-button onClick typing to ColumnButtonClickEvent. |
| packages/devextreme-angular/src/ui/tree-list/nested/button-dxi.ts | Updates Angular TreeList button onClick typing to ColumnButtonClickEvent. |
| packages/devextreme-angular/src/ui/nested/button-dxi.ts | Removes onClick from generic dxi-button inputs (text editor button config). |
| packages/devextreme-angular/src/ui/nested/base/text-editor-button-dxi.ts | Removes incorrect onClick accessor and unrelated ColumnButtonClickEvent import from the text-editor button base. |
…T1319919 # Conflicts: # packages/devextreme-react/src/tree-list.ts # packages/devextreme-vue/src/tree-list.ts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 5 out of 7 changed files in this pull request and generated 1 comment.
|
LGTM |
…e onClick event type (T1319919) (DevExpress#32404)
…e onClick event type (T1319919) (DevExpress#32404) # Conflicts: # packages/devextreme-angular/src/ui/tree-list/nested/button-dxi.ts # packages/devextreme-angular/src/ui/tree-list/nested/column-button-dxi.ts # packages/devextreme-metadata/make-angular-metadata.ts # packages/devextreme-react/src/tree-list.ts # packages/devextreme-vue/src/tree-list.ts
Cherry-picks
Patch for:
Docs: