Scheduler: QUnit tests: ensure compatibility with Fluent and drop Generic theme testing by aleksei-semikozov · Pull Request #32470 · DevExpress/DevExtreme

aleksei-semikozov · 2026-02-09T08:53:48Z

No description provided.

…sPerCell option

…ppointment tests

…cheduler tests

…tests

…d value

…cheduler tests and adjust width assertions

…cheduler tests and update expected values

…t values in virtual scrolling month view tests

…ration in scheduler tests

…ues in scheduler tests

…ion values in timeline tests

…alues in grouping by date tests

…positions in scheduler tests

…position values in layout manager tests

…position values in contentReadyEvent tests

…osition values in DateTime indicator tests

Copilot

Pull request overview

This PR updates DevExtreme QUnit integration tests to stop relying on the removed generic_light theme by switching them to fluent_blue_light, and re-baselines size/position assertions (widths/heights/offsets) affected by the theme change.

Changes:

Replaced generic_light.css! imports with fluent_blue_light.css! across Scheduler, PivotGrid, and Knockout Scheduler tests.
Updated many pixel-based expectations (sizes/positions/scroll offsets/rects) to match Fluent theme rendering.
Adjusted a few test setups/options (e.g., maxAppointmentsPerCell, container sizes) to keep scenarios stable under the new theme.

Reviewed changes

Copilot reviewed 27 out of 27 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
packages/devextreme/testing/tests/DevExpress.ui.widgets.scheduler/workSpaceWithHorizontalScroll.tests.js	Switch theme import and update workspace width expectations for Fluent.
packages/devextreme/testing/tests/DevExpress.ui.widgets.scheduler/workSpace.week.tests.js	Switch theme import and update visible bounds expectations under Fluent.
packages/devextreme/testing/tests/DevExpress.ui.widgets.scheduler/workSpace.month.tests.js	Switch theme import and update group header height/width assertions.
packages/devextreme/testing/tests/DevExpress.ui.widgets.scheduler/workSpace.base.tests.js	Switch theme import and update min-width expectations.
packages/devextreme/testing/tests/DevExpress.ui.widgets.scheduler/workSpace.api.tests.js	Switch theme import and update coordinate-based index tests.
packages/devextreme/testing/tests/DevExpress.ui.widgets.scheduler/virtual_scrolling.timeline.tests.js	Switch theme import and re-baseline expected rect positions.
packages/devextreme/testing/tests/DevExpress.ui.widgets.scheduler/virtual_scrolling.monthView.tests.js	Switch theme import and re-baseline virtual scrolling rect expectations (including some empty expected sets).
packages/devextreme/testing/tests/DevExpress.ui.widgets.scheduler/virtual_scrolling.integration.tests.js	Switch theme import and re-baseline integration virtual scrolling expectations (rects/indices/settings).
packages/devextreme/testing/tests/DevExpress.ui.widgets.scheduler/timezones.tests.js	Switch theme import and update expected popup positioning.
packages/devextreme/testing/tests/DevExpress.ui.widgets.scheduler/timeline.tests.js	Switch theme import and update scroll sync and cell height-related expectations.
packages/devextreme/testing/tests/DevExpress.ui.widgets.scheduler/subscribes.tests.js	Switch theme import and update expected appointment coordinates.
packages/devextreme/testing/tests/DevExpress.ui.widgets.scheduler/pacificTime.tests.js	Switch theme import and update DST-related position/selection/count assertions.
packages/devextreme/testing/tests/DevExpress.ui.widgets.scheduler/layoutManager.tests.js	Switch theme import; re-baseline many appointment sizing/position assertions; adjust some `maxAppointmentsPerCell` usage.
packages/devextreme/testing/tests/DevExpress.ui.widgets.scheduler/currentTimeIndicator.tests.js	Switch theme import and re-baseline shader/indicator size/position assertions.
packages/devextreme/testing/tests/DevExpress.ui.widgets.scheduler/contentReadyEvent.tests.js	Switch theme import and update expected appointment render positions.
packages/devextreme/testing/tests/DevExpress.ui.widgets.scheduler/common.tests.js	Switch theme import; update test setup options and default cell height expectations.
packages/devextreme/testing/tests/DevExpress.ui.widgets.scheduler/common.initialization.tests.js	Switch theme import for initialization tests.
packages/devextreme/testing/tests/DevExpress.ui.widgets.scheduler/appointment.week.based.views.tests.js	Switch theme import and update expected appointment coordinates for integration scenarios.
packages/devextreme/testing/tests/DevExpress.ui.widgets.scheduler/appointment.timeLines.tests.js	Switch theme import and update appointment top offset constant.
packages/devextreme/testing/tests/DevExpress.ui.widgets.scheduler/appointment.templates.tests.js	Switch theme import and adjust template test case options for Fluent behavior.
packages/devextreme/testing/tests/DevExpress.ui.widgets.scheduler/appointment.scroll.tests.js	Switch theme import and adjust viewport sizing for scroll scenario stability.
packages/devextreme/testing/tests/DevExpress.ui.widgets.scheduler/appointment.monthView.tests.js	Switch theme import; update offsets and appointment layout expectations in month view.
packages/devextreme/testing/tests/DevExpress.ui.widgets.scheduler/allDayAppointments.common-1.tests.js	Switch theme import and update all-day appointment positioning assertions.
packages/devextreme/testing/tests/DevExpress.ui.widgets.scheduler/allDayAppointments.common-0.tests.js	Switch theme import; adjust max-per-cell related assertions and dropdown behavior expectations.
packages/devextreme/testing/tests/DevExpress.ui.widgets.pivotGrid/pivotGrid.tests.js	Switch theme import; update multiple size/scrolling/virtualization expectations for Fluent.
packages/devextreme/testing/tests/DevExpress.ui.widgets.pivotGrid/export.tests.js	Switch theme import and adjust icon-size assertion logic for Fluent.
packages/devextreme/testing/tests/DevExpress.knockout/scheduler.tests.js	Switch theme require and adjust KO scheduler collector scenario data/setup.

Copilot · 2026-02-09T09:04:16Z

packages/devextreme/testing/tests/DevExpress.ui.widgets.scheduler/common.tests.js

 import { getTimeZones } from 'time_zone_utils';

-import { createWrapper, initTestMarkup } from '../../helpers/scheduler/helpers.js';
+import { createWrapper, initTestMarkup, moveSchedulerToMainBlock } from '../../helpers/scheduler/helpers.js';


moveSchedulerToMainBlock is imported but never used in this file. This will typically fail linting (unused import); please remove it or use it where intended.

Copilot · 2026-02-09T09:04:16Z

packages/devextreme/testing/tests/DevExpress.ui.widgets.scheduler/layoutManager.tests.js

            type: 'month',
            name: 'MONTH',
-            maxAppointmentsPerCell: 'auto'
+            maxAppointmentsPerCell: '2'


maxAppointmentsPerCell expects a number or one of the string literals 'auto' | 'unlimited'. Passing '2' as a string is an invalid option type and can cause runtime/type issues; use a numeric value instead.

Suggested change

maxAppointmentsPerCell: '2'

maxAppointmentsPerCell: 2

Copilot · 2026-02-09T09:04:16Z

packages/devextreme/testing/tests/DevExpress.ui.widgets.pivotGrid/export.tests.js

 import executeAsyncMock from '../../helpers/executeAsyncMock.js';
-import { checkDxFontIcon, DX_ICON_XLSX_FILE_CONTENT_CODE } from '../../helpers/checkDxFontIconHelper.js';
+import { DX_ICON_XLSX_FILE_CONTENT_CODE } from '../../helpers/checkDxFontIconHelper.js';

 import 'ui/pivot_grid/ui.pivot_grid';
-import 'generic_light.css!';
+import 'fluent_blue_light.css!';
+
+function checkDxFontIcon(assert, dxIconSelector, expectedIconCode) {
+    const FLUENT_BASE_ICON_SIZE = 20;
+
+    const iconBeforeElementStyle = getComputedStyle($(dxIconSelector).get(0), ':before');
+    assert.strictEqual(iconBeforeElementStyle.content.charCodeAt(1), expectedIconCode, `icon code (${dxIconSelector})`);
+    const iconElementStyle = getComputedStyle($(dxIconSelector).get(0));
+    assert.strictEqual(iconElementStyle.width, FLUENT_BASE_ICON_SIZE + 'px', `icon element width (${dxIconSelector})`);
+    assert.strictEqual(iconElementStyle.height, FLUENT_BASE_ICON_SIZE + 'px', `icon element height (${dxIconSelector})`);
+}


This file redefines checkDxFontIcon, duplicating logic from the shared testing/helpers/checkDxFontIconHelper.js. To avoid divergence across tests, consider updating the shared helper to support Fluent icon sizing (or accept a base-size parameter) and keep using the shared helper here.

Copilot · 2026-02-09T09:04:17Z

...evextreme/testing/tests/DevExpress.ui.widgets.scheduler/allDayAppointments.common-0.tests.js


                scheduler.instance.option('dataSource', items);
                await waitForAsync(() => scheduler.appointments.getAppointments().length === 3);
+                // moveSchedulerToMainBlock();


Leftover commented-out call (// moveSchedulerToMainBlock();) looks like debugging scaffolding. Please remove it to keep the test clean and avoid confusion about required setup.

Suggested change

// moveSchedulerToMainBlock();

aleksei-semikozov added 21 commits February 5, 2026 18:14

Scheduler: switch from generic to fluent_blue_light theme

d223d1e

Merge branch '26_1' into Devextreme_2683

e2acbcf

Fix icon test

cba0ccb

fix(tests): update allDayAppointments tests to include maxAppointment…

3bbccd1

…sPerCell option

fix(tests): switch from generic_light to fluent_blue_light theme in a…

5151c1d

…ppointment tests

fix(tests): switch from generic_light to fluent_blue_light theme in s…

9db58d4

…cheduler tests

fix(tests): adjust height and width parameters in appointment scroll …

32a51d2

…tests

fix(tests): add maxAppointmentsPerCell option to recurrence test

547caca

fix(tests): update appointment width in T712431 test to match expecte…

3edf6c4

…d value

fix(tests): switch from generic_light to fluent_blue_light theme in s…

7838ef9

…cheduler tests and adjust width assertions

fix(tests): switch from generic_light to fluent_blue_light theme in s…

b8cdaf6

…cheduler tests and update expected values

fix(tests): switch to fluent_blue_light theme and update expected rec…

0492e99

…t values in virtual scrolling month view tests

Implement feature X to enhance user experience and fix bug Y in module Z

572f968

fix(tests): add maxAppointmentsPerCell property to month view configu…

28863bd

…ration in scheduler tests

fix(tests): switch to fluent_blue_light theme and adjust position val…

8bc59e8

…ues in scheduler tests

fix(tests): switch to fluent_blue_light theme and adjust scroll posit…

2ed7cba

…ion values in timeline tests

fix(tests): switch to fluent_blue_light theme and update coordinate v…

69efa3c

…alues in grouping by date tests

fix(tests): switch to fluent_blue_light theme and adjust appointment …

8875e5d

…positions in scheduler tests

fix(tests): switch to fluent_blue_light theme and update appointment …

78a3fd9

…position values in layout manager tests

fix(tests): switch to fluent_blue_light theme and update appointment …

947ec37

…position values in contentReadyEvent tests

fix(tests): switch to fluent_blue_light theme and update height and p…

b1812ee

…osition values in DateTime indicator tests

aleksei-semikozov self-assigned this Feb 9, 2026

aleksei-semikozov requested a review from a team as a code owner February 9, 2026 08:53

Copilot AI review requested due to automatic review settings February 9, 2026 08:53

aleksei-semikozov added the 26_1 label Feb 9, 2026

aleksei-semikozov changed the title ~~Remove generic theme~~ Scheduler: QUnit tests: ensure compatibility with Fluent and drop Generic theme testing Feb 9, 2026

Merge branch '26_1' into remove-generic-theme

bf98b7c

Copilot started reviewing on behalf of aleksei-semikozov February 9, 2026 08:54 View session

Copilot AI reviewed Feb 9, 2026

View reviewed changes

aleksei-semikozov added the skip-cache label Feb 9, 2026

aleksei-semikozov added the force all tests label Feb 9, 2026

aleksei-semikozov closed this Feb 9, 2026

aleksei-semikozov reopened this Feb 9, 2026

Merge branch '26_1' into remove-generic-theme

e835cec

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Scheduler: QUnit tests: ensure compatibility with Fluent and drop Generic theme testing#32470

Scheduler: QUnit tests: ensure compatibility with Fluent and drop Generic theme testing#32470
aleksei-semikozov wants to merge 23 commits intoDevExpress:26_1from
aleksei-semikozov:remove-generic-theme

aleksei-semikozov commented Feb 9, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Feb 9, 2026

Uh oh!

Copilot AI Feb 9, 2026

Uh oh!

Copilot AI Feb 9, 2026

Uh oh!

Copilot AI Feb 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

aleksei-semikozov commented Feb 9, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Feb 9, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 9, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 9, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 9, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant