TextEditorButtonCollection: Improve TS #32536
Merged
+32
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r-farkhutdinov
approved these changes
Feb 12, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves TypeScript type safety in the TextEditorButtonCollection component by removing @ts-expect-error comments and adding proper type definitions.
Changes:
- Enhanced the
TextEditorButtonInfotype to explicitly includename: stringand usetypeof CustomButtoninstead of justCustomButton - Refactored button mapping logic to handle string and object buttons separately with proper type guards
- Updated error handling to use proper
Errorobjects instead of throwing strings
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| m_index.ts | Improved type definitions for TextEditorButtonInfo, refactored button validation logic, and removed TypeScript error suppressions |
| m_button.ts | Added null support to $container type, changed string throws to Error objects, and removed unnecessary TypeScript error suppressions |
packages/devextreme/js/__internal/ui/text_box/texteditor_button_collection/m_index.ts
Show resolved
Hide resolved
packages/devextreme/js/__internal/ui/text_box/texteditor_button_collection/m_index.ts
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.