include from same dir

[dg0yt]

thread_safe_queue.h is in the same directory as thread_pool.h.

The original path prefix made #include "..." perform worse, because the first attempt (same dir) would always fail, and it requires user to have the parent dir of thread_pool in the header search path.

[DeveloperPaul123]

Just curious: How are you including thread-pool in your project?

[dg0yt]

Just curious: How are you including thread-pool in your project?

The original issue was reported for thread-pool installed in Visual Studio via vcpkg, using

#include <thread-pool-0.7.0/thread_pool/thread_pool.h>

I still think it shouldn't be used with this statement. But I noticed that a simple change could resolve that issue and improve regular use (installed CMake, sub-project, whatever).

[UMU618]

Just curious: How are you including thread-pool in your project?

Better #include <thread_pool/thread_pool.h>, but vcpkg install dp-thread-pool to a versioned path(%VCPKG_ROOT%\installed\x64-windows\include\thread-pool-0.7.0\thread_pool), which I think it's wrong.

[UMU618]

[dg0yt]

vcpkg install dp-thread-pool to a versioned path(%VCPKG_ROOT%\installed\x64-windows\include\thread-pool-0.7.0\thread_pool), which I think it's wrong.

The installation of the header is made by this pristine command;

thread-pool/CMakeLists.txt

Lines 130 to 135 in 03f4b67

	install(FILES ${headers}
	DESTINATION ${CMAKE_INSTALL_INCLUDEDIR}/${PROJECT_NAME}-${PROJECT_VERSION}/thread_pool
	)
	install(FILES ${PROJECT_BINARY_DIR}/include/thread_pool/version.h
	DESTINATION ${CMAKE_INSTALL_INCLUDEDIR}/${PROJECT_NAME}-${PROJECT_VERSION}/thread_pool
	)

But this is not the topic of this PR.

[DeveloperPaul123]

Just curious: How are you including thread-pool in your project?

Better #include <thread_pool/thread_pool.h>, but vcpkg install dp-thread-pool to a versioned path(%VCPKG_ROOT%\installed\x64-windows\include\thread-pool-0.7.0\thread_pool), which I think it's wrong.

Yes my original idea was to allow for multiple versions to be installed side-by-side but I realize now that it's not idiomatic to do that 😅 Certainly something that can be fixed in the future.

[DeveloperPaul123]

Once I have time to pull this locally and test it should be good to merge