Skip to content

Conversation

@GDYendell
Copy link
Contributor

Needs work in pvi to open plots on a new display and configure axis range

@jsouter
Copy link
Contributor

jsouter commented Nov 14, 2025

epics-containers/pvi#157

I was working on this in pvi this morning, just pushed onto my PR.
FastCS changes in scratch look like

            case Waveform():
                if (length := len(fastcs_datatype.shape)) == 2:
                    default_width = 800
                    height = int(
                        default_width
                        * fastcs_datatype.shape[0]
                        / fastcs_datatype.shape[1]
                    )
                    return ImageRead(
                        width=default_width, height=height, color_map=ImageColorMap.GRAY
                    )
                elif length == 1:
                    return ArrayTrace(axis="")
                else:
                    raise NotImplementedError(
                        f"Waveform shape {fastcs_datatype.shape} not supported"
                    )

Also tries to add XY trace support for edl, though that's disabled in FastCS right now anyway.

@GDYendell GDYendell self-assigned this Nov 14, 2025
@GDYendell GDYendell force-pushed the waveform branch 2 times, most recently from 1ee470b to 35cf5d4 Compare December 22, 2025 13:27
@codecov
Copy link

codecov bot commented Dec 22, 2025

Codecov Report

❌ Patch coverage is 90.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.75%. Comparing base (9ebdf4d) to head (5b3bc92).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/fastcs/transports/epics/pva/gui.py 87.50% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #247      +/-   ##
==========================================
- Coverage   90.83%   90.75%   -0.09%     
==========================================
  Files          70       70              
  Lines        2510     2519       +9     
==========================================
+ Hits         2280     2286       +6     
- Misses        230      233       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@GDYendell GDYendell changed the title WIP - Add Waveform Implement Waveform Dec 22, 2025
@GDYendell GDYendell merged commit 3edcc06 into main Dec 22, 2025
17 of 20 checks passed
@GDYendell GDYendell deleted the waveform branch December 22, 2025 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants