Refactor Methods to allow overridding @command methods
#293
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #293 +/- ##
=======================================
Coverage 90.83% 90.83%
=======================================
Files 70 70
Lines 2488 2510 +22
=======================================
+ Hits 2260 2280 +20
- Misses 228 230 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
GDYendell
force-pushed
the
commands
branch
3 times, most recently
from
423b7b7 to
3a18861
Compare
GDYendell
changed the title
@command methods
GDYendell
force-pushed
the
pva-command-buttons
branch
from
be05c5c to
b375663
Compare
shihab-dls
requested changes
Dec 18, 2025
Tag existing method with __unbound_command__ / __unbound_scan__ instead
of replacing with callable Command / Scan
Check attributes for this metadata in _bind_attrs
Store Command / Scan instances in self.__command_methods / self.__scan
Replace search in build_controller_api with accessing these members
Remove lazy imports from controller and replace with TYPE_CHECKING
import in methods. This feels more natural, as controllers needs methods
for isinstance checks, whereas methods just needs controllers for type
hinting.
e.g.
/workspaces/fastcs-eiger/src/fastcs_eiger/controllers/odin/eiger_odin_controller.py:28:15
- error: "arm_when_ready" overrides symbol of same name in class
"EigerController"
"UnboundCommand[EigerOdinController]" is not assignable to
"UnboundCommand[EigerController]"
Type parameter "Controller_T@UnboundCommand" is invariant, but
"EigerOdinController" is not the same as "EigerController"
(reportIncompatibleVariableOverride)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.