Skip to content

Conversation

@mfep
Copy link
Collaborator

@mfep mfep commented Nov 20, 2025

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have made corresponding changes to the documentation

@mfep mfep force-pushed the remove-stripe-fw-radway-58 branch 2 times, most recently from 1b74285 to f12ba29 Compare December 4, 2025 09:52
@mfep mfep requested a review from dkazanc December 11, 2025 08:52
@mfep mfep self-assigned this Dec 11, 2025
@mfep mfep force-pushed the remove-stripe-fw-radway-58 branch from 1aabc22 to 43b46ca Compare December 16, 2025 13:34
@dkazanc dkazanc self-requested a review December 16, 2025 17:31
Copy link
Collaborator

@dkazanc dkazanc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In HTTomo we also have another runner, a so-called sweep runner that performs a search/sweep over the set of given parameters. Because Paganin filter has a kernel of certain size we must take an area normally bigger or equal to the size of that kernel.
So in this function we try to estimate how large the vertical crop must be based on how many slices fit the GPU memory. This is still calling an older memory estimator and the associated test actually fails as well. So we need to change that bit accordingly. We just need to know that with given parameters how many vertical slices would fit, exactly what the iterative estimator can do. Can this be fixed please?

@dkazanc dkazanc merged commit 48f570c into main Dec 18, 2025
5 of 6 checks passed
@dkazanc dkazanc deleted the remove-stripe-fw-radway-58 branch December 18, 2025 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants