-
Notifications
You must be signed in to change notification settings - Fork 5
Iterative search method for memory estimator #652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
1b74285 to
f12ba29
Compare
Exceptions can be thrown, e.g. when the estimation itself fails due to running out of memory. Test is also added to covert this case.
1aabc22 to
43b46ca
Compare
dkazanc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In HTTomo we also have another runner, a so-called sweep runner that performs a search/sweep over the set of given parameters. Because Paganin filter has a kernel of certain size we must take an area normally bigger or equal to the size of that kernel.
So in this function we try to estimate how large the vertical crop must be based on how many slices fit the GPU memory. This is still calling an older memory estimator and the associated test actually fails as well. So we need to change that bit accordingly. We just need to know that with given parameters how many vertical slices would fit, exactly what the iterative estimator can do. Can this be fixed please?
remove_stripe_fwhttomo-backends#82Checklist