Endpoints to get controller information from instrument server #416
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… running to allow reconnections to sessions following instrument server restarts
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #416 +/- ##
==========================================
- Coverage 27.77% 26.29% -1.48%
==========================================
Files 72 75 +3
Lines 9883 11792 +1909
Branches 1318 1853 +535
==========================================
+ Hits 2745 3101 +356
- Misses 7044 8527 +1483
- Partials 94 164 +70 |
tieneupin
reviewed
Dec 2, 2024
stephen-riggs
approved these changes
Dec 2, 2024
Contributor
stephen-riggs
left a comment
stephen-riggs
left a comment
There was a problem hiding this comment.
Looks fine to me (except for the print statement as Eu Pin pointed out)
tieneupin
reviewed
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add functionality to check what controllers the instrument server has running to allow reconnections to sessions following instrument server restarts