Skip to content

Conversation

@tieneupin
Copy link
Contributor

We used to insert experiment_type into ISPyB as part of the DataCollectionGroup table, but we have been informed that that column is being retired. This PR removes the insert of experiment_type into ISPyB from our repo.

@codecov
Copy link

codecov bot commented Nov 14, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 38.23%. Comparing base (e292f91) to head (fdac7ed).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #693      +/-   ##
==========================================
- Coverage   38.24%   38.23%   -0.01%     
==========================================
  Files          97       97              
  Lines       11594    11593       -1     
  Branches     1529     1529              
==========================================
- Hits         4434     4433       -1     
  Misses       6964     6964              
  Partials      196      196              
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tieneupin tieneupin marked this pull request as ready for review November 18, 2025 10:10
@tieneupin tieneupin requested review from d-j-hatton and stephen-riggs and removed request for stephen-riggs November 18, 2025 10:10
@tieneupin tieneupin self-assigned this Nov 18, 2025
@tieneupin tieneupin added the server Relates to the server component label Nov 18, 2025
@tieneupin tieneupin merged commit 6fc82bd into main Nov 18, 2025
17 checks passed
@tieneupin tieneupin deleted the update-ispyb-inserts branch November 18, 2025 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

server Relates to the server component

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants