Skip to content

Conversation

@stephen-riggs
Copy link
Contributor

@stephen-riggs stephen-riggs commented Dec 8, 2025

A few issues have come up with the user-supplied initial model:

  • The mrc size was not being read from the header
  • Box size and downscaling was updated in cryoemservices but not in murfey so they now disagree
  • The diameter was given is being given to the box size calculation in angstroms but it wanted pixels
  • Relion was not told to force the pixel size, causing 3D classification to crash

@codecov
Copy link

codecov bot commented Dec 8, 2025

Codecov Report

❌ Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 38.51%. Comparing base (c02c9da) to head (e299993).
⚠️ Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #709      +/-   ##
==========================================
- Coverage   38.51%   38.51%   -0.01%     
==========================================
  Files          99       99              
  Lines       11663    11664       +1     
  Branches     1542     1542              
==========================================
  Hits         4492     4492              
- Misses       6973     6974       +1     
  Partials      198      198              
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@tieneupin tieneupin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks fine as-is, but if you could include a brief summary in the PR description of why you had to change form input_mrc.nx... to input_mrc.header.nx... for future reference, that would be helpful.

@stephen-riggs stephen-riggs changed the title Initial model size should be read from header Initial model resizing fixes Dec 8, 2025
@stephen-riggs stephen-riggs merged commit 2d25509 into main Dec 8, 2025
17 checks passed
@stephen-riggs stephen-riggs deleted the ini-model-fix branch December 8, 2025 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants