Bug fixes post-v0.22.1 patch bump #714
Merged
+167
−56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #714 +/- ##
=======================================
Coverage 40.30% 40.30%
=======================================
Files 99 99
Lines 11602 11603 +1
Branches 1553 1554 +1
=======================================
+ Hits 4676 4677 +1
Misses 6708 6708
Partials 218 218 🚀 New features to boost your workflow:
|
tieneupin
changed the title
tieneupin
changed the title
tieneupin
added
bug
stephen-riggs
approved these changes
Dec 12, 2025
Contributor
stephen-riggs
left a comment
stephen-riggs
left a comment
There was a problem hiding this comment.
It's worth you checking my bit of this before we merge! Otherwise all good
tieneupin
commented
Dec 12, 2025
Comment on lines
+177
to
+179
| .where( | ||
| col(DataCollectionGroup.tag).contains(f"/Sample{dcg_params.sample}/Atlas") | ||
| ) |
Contributor
Author
There was a problem hiding this comment.
Did f"/Sample{dcg_params.sample}/Atlas" in DataCollectionGroup.tag not work?
Contributor
Author
There was a problem hiding this comment.
String search not implemented. Have to use SQLModel built-ins
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
get_extended_machine_config()did not call the entry point correctlyepu_session_metadata()extra hook needs the instrument token to useget_machine_config_client()correctlyAlso allows processing runs to be many-to-one with atlases. This requires changes to data collection group registration logic:
SampleX/Atlasin the tag