-
Notifications
You must be signed in to change notification settings - Fork 1
Replace client websocket #716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ment-server' as a key is no longer needed
…sses in; removed CustomHandler
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #716 +/- ##
==========================================
+ Coverage 42.49% 43.19% +0.70%
==========================================
Files 94 94
Lines 10347 10239 -108
Branches 1346 1332 -14
==========================================
+ Hits 4397 4423 +26
+ Misses 5733 5597 -136
- Partials 217 219 +2 🚀 New features to boost your workflow:
|
…, as it is no longer needed
stephen-riggs
approved these changes
Dec 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
client
Relates to the client component
dependencies
documentation
Improvements or additions to documentation
enhancement
New feature or request
server
Relates to the server component
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge PR #715 first.
Replaced Client-Side Websocket Connection-Based Logging with HTTPX One
The websocket connection between the client and the backend server has been unstable, prone to error, and unable to fulfil its role of sending logs to the backend for subsequent forwarding to the logging dashboard. In this PR, the log forwarding logic has been replaced by a HTTPX-based log handler that sends batches of logs to a backend FastAPI endpoint. It also removes the now-defunct websocket-related components from the client end.
Simplifcation of
pyproject.tomlDependency KeysConsequently, the optional dependency keys needed for our
pyproject.tomlfile can also been streamlined. As of this PR, theclientandinstrument-serveroptional dependency keys are no longer needed, as the packages needed to run the instrument server are a subset of those needed to run the backend server, and have thus been integrated into the essential dependencies section. The documentation and GitHub workflows have thus been updated to reflect this.