Skip to content

Conversation

@stephen-riggs
Copy link
Contributor

@stephen-riggs stephen-riggs commented Dec 15, 2025

The rsyncer destination determination was very out-of-date and potentially caused a problem on Krios 3.
This updates the logic and adds some tests.

@codecov
Copy link

codecov bot commented Dec 15, 2025

Codecov Report

❌ Patch coverage is 78.94737% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 42.80%. Comparing base (cdbf693) to head (5ccc085).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #718      +/-   ##
==========================================
+ Coverage   42.49%   42.80%   +0.30%     
==========================================
  Files          94       94              
  Lines       10347    10341       -6     
  Branches     1346     1345       -1     
==========================================
+ Hits         4397     4426      +29     
+ Misses       5733     5696      -37     
- Partials      217      219       +2     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@tieneupin tieneupin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this. Looks good to me, and seems to have worked on all our supported workflows so far.

@tieneupin tieneupin mentioned this pull request Dec 18, 2025
@stephen-riggs stephen-riggs merged commit ae75bb3 into main Dec 19, 2025
17 checks passed
@stephen-riggs stephen-riggs deleted the destination-not-empty branch December 19, 2025 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants