Add a check-and-set to deleteKV without changing return type#202
Open
Anusien wants to merge 1 commit intoEcwid:masterfrom
Open
Add a check-and-set to deleteKV without changing return type#202Anusien wants to merge 1 commit intoEcwid:masterfrom
Anusien wants to merge 1 commit intoEcwid:masterfrom
Conversation
The main dilemma with adding check-and-set to deleteKV is that all the delete KV methods return Response<Void>. Consequently we can't actually return whether the c-a-s worked. We can't change Response<Void> to Response<Boolean> without breaking a lot of existing code. This just adds the capability for check-and-set but punts on the Response<Void> problem. If callers want to see if the delete succeeded, they'll have to do another getKV. However, this is the least invasive version of this change. Ecwid#49
Anusien
changed the title
Author
|
This intentionally doesn't attempt to mess with the return type in the hopes of making incremental progress. Of the four possible solutions I outlined, this is number 1. |
Author
|
The CI failure:
|
Author
|
@vgv any thoughts on approach? |
Author
|
@vgv Did you have a chance to look at this? |
Member
|
Hi, sorry for long response. I will look into PR this weekend. |
Author
|
Just curious if you had a chance to look at this or any opinions on the approach. |
|
Hello! I am following up on this. Are there any concerns about this @vgv? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The main dilemma with adding check-and-set to deleteKV is that all the
delete KV methods return Response. Consequently we can't actually
return whether the c-a-s worked. We can't change Response to
Response without breaking a lot of existing code.
This just adds the capability for check-and-set but punts on the
Response problem. If callers want to see if the delete succeeded,
they'll have to do another getKV. However, this is the least invasive
version of this change.
#49