fix(semantic_token): find decl before check global var

[phanen]

In this case, next should not colored as "defaultlibary"

local next = "wefw"
print(next)
next("wef")

[gemini-code-assist]

Summary of Changes

Hello @phanen, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses an issue where the semantic tokenization incorrectly colored locally declared variables that shared names with Lua's built-in global functions. By adjusting the order of checks, the system now correctly identifies and colors local declarations first, resolving the misidentification of local variables as global library functions and improving the accuracy of semantic highlighting.

Highlights

• Semantic Token Coloring Logic: The logic for determining semantic token types has been updated to prioritize local declarations over built-in global variable checks. This prevents local variables from being incorrectly identified as global library functions.
• Handling of Lua Built-in Globals: The check for Lua built-in global variables (like next, print, etc.) now only occurs if no local declaration for the given name is found, ensuring correct semantic highlighting for shadowed global names.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly addresses an issue where local variables that shadow Lua built-in functions were being incorrectly highlighted. The fix properly prioritizes searching for a declaration before checking if the identifier is a built-in global. The implementation is also more efficient by reusing the result of the declaration search, thus avoiding a redundant call to find_decl. The changes are logical and effectively resolve the bug.