Conversation
🦋 Changeset detectedLatest commit: d1a5be4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Visit the preview URL for this PR (updated for commit d1a5be4): https://react-kitchen-sink-dev--pr1005-185-modularize-icons-9hcvk2ay.web.app (expires Fri, 14 Feb 2025 12:59:47 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 6267897ade2ba783b6db70a53a60fc3946d625e9 |
evshi
left a comment
There was a problem hiding this comment.
This should be generalized to allow any IconSet, not just specially handing MUI Icons.
If you don't import the entire icon set and instead only import the ones that are used, does that reduce the bundle size further?
evshi
left a comment
There was a problem hiding this comment.
Can you add some tests for Icon/Avatar component.
Describe your changes
reduce runtime bundle size by modularize icons
Screenshots [Optional]
Issue ticket number and link
Closes #185
Checklist before requesting a review
pnpm changeset add