added support of dynamic searchKey in search widget#1008
Open
sagardspeed2 wants to merge 3 commits intomainfrom
Open
added support of dynamic searchKey in search widget#1008sagardspeed2 wants to merge 3 commits intomainfrom
sagardspeed2 wants to merge 3 commits intomainfrom
Conversation
🦋 Changeset detectedLatest commit: 028e0b0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Visit the preview URL for this PR (updated for commit 028e0b0): https://react-kitchen-sink-dev--pr1008-1006-support-dynamic-bw9a0tyf.web.app (expires Fri, 31 Jan 2025 20:25:15 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 6267897ade2ba783b6db70a53a60fc3946d625e9 |
evshi
reviewed
Jan 24, 2025
Contributor
evshi
left a comment
evshi
left a comment
There was a problem hiding this comment.
can you add a test for a static search key also.
evshi
approved these changes
Jan 24, 2025
| values?.searchKey | ||
| ? [itemTemplate?.name ?? "", values.searchKey] | ||
| : [(itemTemplate?.value || itemTemplate?.name) ?? ""], | ||
| : itemTemplate?.value || itemTemplate?.name || "", |
Contributor
There was a problem hiding this comment.
Did you mean to remove this here?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Screenshots [Optional]
Issue ticket number and link
Closes #1006
Checklist before requesting a review
pnpm changeset add