Enhance DB indices on C++ metrics tables #797
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcserep
added
Plugin: C++
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enhances DB querying performance on C++ metrics tables by adding indexing directives to key fields.
- Added DB indices for dependency and file metrics for faster querying.
- Added an index for AST node metrics to optimize lookups.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| plugins/cpp_metrics/model/include/model/cpptypedependencymetrics.h | Added DB indices for entityHash and dependencyHash |
| plugins/cpp_metrics/model/include/model/cppfilemetrics.h | Added a DB index for file |
| plugins/cpp_metrics/model/include/model/cppastnodemetrics.h | Added a DB index for astNodeId |
Comments suppressed due to low confidence (1)
plugins/cpp_metrics/model/include/model/cpptypedependencymetrics.h:28
- The index is being created on 'entityHash', yet this member is not visible in the structure diff. Please verify that 'entityHash' exists or update the index to target the correct member.
#pragma db index member(entityHash)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These metrics are required for efficient querying of metrics in the service layer, especially for paginated queries for large project.