Skip to content

Conversation

@wcastand
Copy link

@wcastand wcastand commented Oct 3, 2025

Details

Adding an expo plugin to allow to use this library with expo CNG.
Adding documentation on how to configure and do.

I make the draft quickly mostly because i'm rusty on open source contribution. never really did an expo plugin as part of a public lib (always internal plugins and modules). We use biome and bun so didn't use prettier/eslint and npm in 4 years pretty much 😅

so i will need some guidance or help to make this a clean PR, sorry in advance.

Related Issues

#31

Manual Tests

i added an expo example app with the plugin in the config, not sure how to test since it needs the private lib for google pay.

TODO

  • add expo plugin code
  • add documentation
  • add expo app example
  • fix eslint config issues with new plugin code

@github-actions
Copy link

github-actions bot commented Oct 3, 2025

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@wcastand
Copy link
Author

wcastand commented Oct 3, 2025

I have read the CLA Document and I hereby sign the CLA

CLABotify added a commit to Expensify/CLA that referenced this pull request Oct 3, 2025
@wcastand wcastand marked this pull request as ready for review October 6, 2025 10:03
@adnandothussain
Copy link

@wcastand any updates when this will be merged?

@wcastand
Copy link
Author

@adnandothussain that's not on me unfortunately, i made the Pr never received feedback so before i ever look at conflict, i expect them to spend some time for review before i spend more time on it especially since conflict is just package maintenance most likely.

@adnandothussain
Copy link

Thank you for your response @wcastand
Any way i can integrate react-native-wallet in my existing expo app? If this PR will take some time?

@wcastand
Copy link
Author

You can do yeah we have it in prod right now
You need to to make custom local plugin and you should be able to

@adnandothussain
Copy link

By using your Gist https://gist.github.com/wcastand/4160c31062e085b043e4d78953642150

I have created expo plugin. Will it work in Prod?

@wcastand
Copy link
Author

well test, i don't know your setup so i can't guarantee it, it works for us at least. 😅

@zfurtak
Copy link
Collaborator

zfurtak commented Jan 19, 2026

Sorry guys for waiting! Thanks a lot for collaboration!! 💪
I'm a bit occupied right now but will try to review it asap 😉

@zfurtak
Copy link
Collaborator

zfurtak commented Jan 19, 2026

Could you resolve conflicts?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, I can't run the expo app, I'm getting errors when launching it on iOS

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same on Android

 ERROR  ExceptionsManager should be set up after React DevTools to avoid console.error arguments mutation
 ERROR  [TypeError: property is not writable]
 ERROR  [TypeError: Cannot read property 'default' of undefined]
 ERROR  [TypeError: property is not writable]
 ERROR  [TypeError: Cannot read property 'default' of undefined]

@Skalakid
Copy link
Collaborator

@wcastand than you very much for the PR, sorry for the delay with the review; I didn't have the bandwidth to check your changes. I left some comments. Please resolve them, and we can proceed with merging your changes. The plugin itself looks good and works well

AndrewGable and others added 6 commits January 22, 2026 10:54
- Convert example-expo/App.js to TypeScript (App.tsx)
- Remove plugin/tsconfig.tsbuildinfo and add *.tsbuildinfo to .gitignore
- Move Expo plugin documentation to Installation section in README
- Revert package.json formatting from tabs to spaces while keeping functional changes
- Regenerate package-lock.json with correct formatting
- Fix expo app to use simple UI that won't cause runtime errors

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@zfurtak zfurtak requested a review from Skalakid January 22, 2026 11:12
@wcastand
Copy link
Author

well i give up lol
the monorepo break the expo example, works and build fine outside of repo, break in it tried many things, it's broken for monorepo, not the actual code.

i rebase but getting package conflict in a loop, honestly i wanted to help but it's been like 6 month and kind of not up to deal with package json conflict ever again at this point lol.

@Skalakid
Copy link
Collaborator

@wcastand I totally get it. Don't worry, the core logic you wrote is what matters. I will take it from here. Thanks for all the effort you put into this and sorry for the delay with the review

@wcastand
Copy link
Author

thanks for the package, and sorry again for not figure this one out, package json conflict got to me this morning 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants