fix: empty channelId in test environment#405
Open
wneel wants to merge 6 commits intoFirebaseExtended:mainfrom
Open
fix: empty channelId in test environment#405wneel wants to merge 6 commits intoFirebaseExtended:mainfrom
wneel wants to merge 6 commits intoFirebaseExtended:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I figured out that the problem I was having in #403 was occurring because I was using act. But i then saw that there is no default case in the
getChannelIdfunction.By adding this
elsestatement, I'm ensuring that the channelId has a valid value before passing it tofirebase-tools, otherwise errors will occur and it's hard to debug.Now, here is the error I get when not using a channelId in a test environment:
And of course, according to the guidelines I've run:
before opening the PR :)
I'm available for any changes or questions, I hope everything sounds good to you.