-
Notifications
You must be signed in to change notification settings - Fork 468
fix: disable blanket API throttling in favour of WAF #6642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Blanket throttling is now managed through WAF. This removes the default UserRateThrottle and MasterAPIKeyUserRateThrottle classes from staging and production, and sets their default rates to None.
|
The latest updates on your projects. Learn more about Vercel for GitHub. 3 Skipped Deployments
|
Docker builds report
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6642 +/- ##
=======================================
Coverage 98.18% 98.18%
=======================================
Files 1295 1295
Lines 46968 46968
=======================================
Hits 46115 46115
Misses 853 853 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
khvn26
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Thanks for submitting a PR! Please check the boxes below:
docs/if required so people know about the feature.Changes
Blanket API throttling is now managed through WAF. This PR:
USER_THROTTLE_RATEandMASTER_API_KEY_THROTTLE_RATEtoNoneinapi/app/settings/common.pyDEFAULT_THROTTLE_CLASSES,USER_THROTTLE_CACHE_*, andMASTER_API_KEY_THROTTLE_RATEenvironment variables from staging and production ECS task definitionsPer-endpoint throttling (login, signup, mfa_code, invite, influx_query) remains unchanged.
How did you test this code?
Configuration change only - verified that:
None