Skip to content

Conversation

@gagantrivedi
Copy link
Member

Thanks for submitting a PR! Please check the boxes below:

  • I have read the Contributing Guide.
  • I have added information to docs/ if required so people know about the feature.
  • I have filled in the "Changes" section below.
  • I have filled in the "How did you test this code" section below.

Changes

Blanket API throttling is now managed through WAF. This PR:

  • Sets default USER_THROTTLE_RATE and MASTER_API_KEY_THROTTLE_RATE to None in api/app/settings/common.py
  • Removes DEFAULT_THROTTLE_CLASSES, USER_THROTTLE_CACHE_*, and MASTER_API_KEY_THROTTLE_RATE environment variables from staging and production ECS task definitions

Per-endpoint throttling (login, signup, mfa_code, invite, influx_query) remains unchanged.

How did you test this code?

Configuration change only - verified that:

  • Default throttle rates are set to None
  • Per-endpoint throttle rates remain configured
  • ECS task definitions no longer include blanket throttle environment variables

Blanket throttling is now managed through WAF. This removes the default
UserRateThrottle and MasterAPIKeyUserRateThrottle classes from staging
and production, and sets their default rates to None.
@gagantrivedi gagantrivedi requested review from a team as code owners February 2, 2026 12:20
@gagantrivedi gagantrivedi requested review from emyller and removed request for a team February 2, 2026 12:20
@vercel
Copy link

vercel bot commented Feb 2, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

3 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs Ignored Ignored Feb 2, 2026 0:20am
flagsmith-frontend-preview Ignored Ignored Feb 2, 2026 0:20am
flagsmith-frontend-staging Ignored Ignored Feb 2, 2026 0:20am

Request Review

@github-actions github-actions bot added api Issue related to the REST API infrastructure fix and removed infrastructure labels Feb 2, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Feb 2, 2026

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-e2e:pr-6642 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api-test:pr-6642 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-frontend:pr-6642 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-api:pr-6642 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-6642 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-6642 Finished ✅ Results

@codecov
Copy link

codecov bot commented Feb 2, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.18%. Comparing base (2d31fb4) to head (aef974d).
⚠️ Report is 12 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6642   +/-   ##
=======================================
  Coverage   98.18%   98.18%           
=======================================
  Files        1295     1295           
  Lines       46968    46968           
=======================================
  Hits        46115    46115           
  Misses        853      853           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@khvn26 khvn26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

emyller
emyller previously requested changes Feb 2, 2026
@gagantrivedi gagantrivedi requested a review from emyller February 3, 2026 02:03
@gagantrivedi gagantrivedi removed the request for review from emyller February 4, 2026 02:05
@gagantrivedi gagantrivedi merged commit 9d53063 into main Feb 4, 2026
33 checks passed
@gagantrivedi gagantrivedi deleted the feature/disable-blanket-throttling branch February 4, 2026 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api Issue related to the REST API fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants