Skip to content

Conversation

@javier-godoy
Copy link
Member

@javier-godoy javier-godoy commented Jan 19, 2026

Summary by CodeRabbit

  • Chores
    • Updated project version to 3.0.0.
    • Bumped Vaadin baseline to 24.8.14.
    • Updated key dependencies (commons-demo, grid-helpers, error-window) to newer major versions.
    • Added an optional Maven profile providing Vaadin 25.0.3 and Java 21 (compiler target).

✏️ Tip: You can customize this high-level summary in your review settings.

@javier-godoy javier-godoy requested a review from mlopezFC January 19, 2026 13:43
@coderabbitai
Copy link

coderabbitai bot commented Jan 19, 2026

Walkthrough

Project version bumped to 3.0.0-SNAPSHOT; Vaadin baseline updated to 24.8.14; several dependency versions updated; new Maven profile v25 added (Java 21, Vaadin 25.0.3, adds vaadin-dev); removed @NotThreadSafe from a test class and updated copyright year.

Changes

Cohort / File(s) Summary
Build Configuration
pom.xml
Project version → 3.0.0-SNAPSHOT; vaadin.version 24.3.9 → 24.8.14; dependency versions updated: commons-demo 4.1.0 → 5.0.0, org.vaadin.addons:flowingcode:grid-helpers 1.3.2 → 2.0.0, com.flowingcode.vaadin.addons:error-window-vaadin 3.4.0 → 4.2.0; added Maven profile v25 setting maven.compiler.source/target = 21, vaadin.version = 25.0.3, and adding com.vaadin:vaadin-dev.
Test File
src/test/java/com/flowingcode/vaadin/addons/gridexporter/test/ConcurrentExportTests.java
Removed @net.jcip.annotations.NotThreadSafe annotation from the test class; updated copyright year range 2022-2024 → 2022-2026.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Suggested reviewers

  • mlopezFC
  • paodb
🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Title check ⚠️ Warning The title focuses on upgrading grid-helpers to 2.0.0, but the changeset includes multiple significant dependency upgrades (Vaadin 24.3.9→24.8.14, commons-demo 4.1.0→5.0.0, error-window-vaadin 3.4.0→4.2.0), a major version bump (2.5.3→3.0.0), and a new v25 Maven profile—making the title narrowly focused on one aspect rather than the main point. Revise the title to reflect the broader scope, such as 'build!: upgrade dependencies and add Vaadin 25 support' or similar, to accurately represent all major changes in the changeset.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@javier-godoy javier-godoy requested a review from paodb January 19, 2026 13:44
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In `@pom.xml`:
- Around line 596-610: The v25 Maven profile (profile id "v25") currently sets
<jetty.version>11.0.26</jetty.version> which is incompatible with Vaadin 25
(vaadin.version 25.0.3) because Vaadin 25 requires Jetty 12 (Servlet 6 / Jakarta
EE 11); change the jetty.version used for Vaadin 25 to a 12.x release and remove
the redundant jetty.version override from the v25 profile, or alternatively set
jetty.version to 12.x at the global properties level if all profiles can use
Jetty 12—update the <jetty.version> property accordingly and ensure only one
authoritative declaration remains.

@sonarqubecloud
Copy link

@javier-godoy javier-godoy marked this pull request as ready for review January 19, 2026 14:02
@paodb paodb merged commit de34f21 into master Jan 19, 2026
4 checks passed
@paodb paodb deleted the vaadin25 branch January 19, 2026 15:46
<dependencies>
<dependency>
<groupId>com.vaadin</groupId>
<artifactId>vaadin-dev</artifactId>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regarding upgrade guide, this dependency should be optional.

<dependency>
    <groupId>com.vaadin</groupId>
    <artifactId>vaadin-dev</artifactId>
    <optional>true</optional>
</dependency>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants