Skip to content

refactor: Centralize error output #3902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
arng40 wants to merge 239 commits into
base: develop
Choose a base branch
from
Open

refactor: Centralize error output #3902

arng40 wants to merge 239 commits into from
+1,251 −722

Conversation

@arng40
Copy link
Contributor

@arng40 arng40 commented Nov 5, 2025 •
edited
Loading

Remove code duplication found in GEOS_THROW, GEOS_ERROR, GEOS_WARNING and put into a static function in ErrorLogger.
Called while flushErrorMsg().
Move all Exceptions under GeosExceptions.hpp

@amandinehry
creation of an object header that logs errors and warnings in a yaml …
c846586 
…file
@amandinehry
Set up ErrorHandling
f1713fa
@amandinehry
traits errors commented (to treat)
4e5250f
@amandinehry
Set up test
94b775c
@amandinehry
Modification to properly format the yaml so that it can be parsed if …
1cb8aa3 
…necessary
@amandinehry
Test to add variadic arguments
9d5e16a
@amandinehry
draft: retrieve data contexts info
2f7660c
@amandinehry
Added additional information in the yaml - not functional missing the…
6036551 
… link between GEOS_THROW_CTX_IF and LVARRAY_THROW_IF_TEST( EXP, MSG, TYPE )
@amandinehry
First attempt at outputting exceptions
46b4904
@amandinehry
Complete: code for outputting errors into yaml
e1aed93
@amandinehry
Manage the text contained in the potential exception
bc953be
@amandinehry
First attempt: Handling the text contained in the potential exception…
1a434bc 
… in try/catch statements

Problem: Retrieves everything that was thrown, so not just the message.
@amandinehry
Complete: yaml output for PVT tables error
acf4d99
@amandinehry
YAML error message well formatted
ee58884
@amandinehry
Fix duplication error
32a0237
@amandinehry
Add variadic parameters to GEOS_THROW_CTX_IF
589270f
@amandinehry
Reorganization after operational tests
9b65581
@amandinehry
Apply the output error functionality in yaml to all geos errors
b13f0a6
@amandinehry
Latest update for exception handling (try/catch in main)
6de2c6a
@amandinehry
Add priority to the error message into the yaml file
5830aee
@amandinehry
Update of the commit named "latest update for exception handling (try…
2b27c41 
…/catch in main)": remove useless try/catch
@amandinehry
set priority
86f793e
@amandinehry
errors cli modification: add --errors-output
8a8117e
@amandinehry
errors cli modification: add --errors-output
2c0f5aa
@amandinehry
Replace original macros
eb2f691
@amandinehry
Correction: replace original macros
7b5f293
@amandinehry
Modification of the Optional function to accept arguments separated b…
c07b502 
…y spaces.

The previous condition checked whether an argument was present and whether the option was immediately followed by a value like -test"value", which excluded valid cases like -test "value" et -test     "value".
@amandinehry
Reacting with the command line option -e / --errors-output
670ddfa
@amandinehry
Add the rank on which the error is catch for error and warning outputs
d08a30f
@amandinehry
Unit test to check if the contents of the yaml file match exactly wha…
5a6c1a0 
…t is expected.
MelReyCG
MelReyCG reviewed Jan 19, 2026
View reviewed changes
@MelReyCG MelReyCG removed ci: run CUDA builds Allows to triggers (costly) CUDA jobs ci: run integrated tests Allows to run the integrated tests in GEOS CI labels Jan 26, 2026
@arng40 arng40 added ci: run CUDA builds Allows to triggers (costly) CUDA jobs ci: run integrated tests Allows to run the integrated tests in GEOS CI labels Jan 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MelReyCG MelReyCG MelReyCG approved these changes

@rrsettgast rrsettgast Awaiting requested review from rrsettgast rrsettgast is a code owner

@corbett5 corbett5 Awaiting requested review from corbett5 corbett5 is a code owner

@wrtobin wrtobin Awaiting requested review from wrtobin wrtobin is a code owner

@cssherman cssherman Awaiting requested review from cssherman cssherman is a code owner

@herve-gross herve-gross Awaiting requested review from herve-gross

@castelletto1 castelletto1 Awaiting requested review from castelletto1 castelletto1 is a code owner

@jhuang2601 jhuang2601 Awaiting requested review from jhuang2601 jhuang2601 is a code owner

@dkachuma dkachuma Awaiting requested review from dkachuma dkachuma is a code owner

@OmarDuran OmarDuran Awaiting requested review from OmarDuran OmarDuran is a code owner

@sframba sframba Awaiting requested review from sframba sframba is a code owner

@acitrain acitrain Awaiting requested review from acitrain acitrain is a code owner

@frankfeifan frankfeifan Awaiting requested review from frankfeifan frankfeifan is a code owner

@tjb-ltk tjb-ltk Awaiting requested review from tjb-ltk tjb-ltk is a code owner

@victorapm victorapm Awaiting requested review from victorapm victorapm is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@arng40 arng40

Labels

ci: run CUDA builds Allows to triggers (costly) CUDA jobs ci: run integrated tests Allows to run the integrated tests in GEOS CI type: cleanup / refactor Non-functional change (NFC)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@arng40 @MelReyCG @amandinehry