Skip to content

fix(BRepMeshesManifoldInspectionResult): Fixed string function to out… #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BotellaA merged 2 commits into from
Sep 16, 2025
Merged

fix(BRepMeshesManifoldInspectionResult): Fixed string function to out… #153

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8864b85
fix(BRepMeshesManifoldInspectionResult): Fixed string function to out…
MelchiorSchuh Sep 16, 2025
6b85237
added temporary fix to facet manifold test
MelchiorSchuh Sep 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 10 additions & 11 deletions src/geode/inspector/criterion/manifold/brep_meshes_manifold.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,10 @@ namespace geode
{
absl::StrAppend( &message, brep_non_manifold_edges.string() );
}
if( brep_non_manifold_facets.nb_issues() != 0 )
{
absl::StrAppend( &message, brep_non_manifold_facets.string() );
}
if( !message.empty() )
{
return message;
Expand Down Expand Up @@ -254,8 +258,8 @@ namespace geode
absl::StrAppend( &message, polygon_vertex, " " );
}
absl::StrAppend( &message,
" is not manifold: it belongs to an internal "
"surface with only one facet" );
" is not manifold: it belongs to internal surface ",
surface.id().string(), " with only one facet" );
issues.add_issue(
BRepNonManifoldFacet{ facet_vertices, { surface.id() } },
message );
Expand All @@ -266,18 +270,13 @@ namespace geode
bool several_cmvs_on_one_vertex(
absl::Span< const index_t > unique_vertices ) const
{
std::vector< uuid > surfaces;
for( const auto unique_vertex : unique_vertices )
{
std::vector< uuid > components;
for( const auto& cmv :
model().component_mesh_vertices( unique_vertex ) )
if( model().component_mesh_vertices( unique_vertex ).size()
> 1 )
{
if( absl::c_find( components, cmv.component_id.id() )
!= components.end() )
{
return true;
}
components.push_back( cmv.component_id.id() );
return true;
}
}
return false;
Expand Down