-
Notifications
You must be signed in to change notification settings - Fork 2
electron peerDependencies #289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
fe38750
electron peerDependencies
JulienChampagnol f8263d1
fix(Electron): dynamic import
JulienChampagnol bf04011
Merge branch 'next' of https://github.com/Geode-solutions/OpenGeodeWe…
JulienChampagnol 75267f2
Apply prepare changes
JulienChampagnol ead85f7
test await executable_path
JulienChampagnol e421fa2
Merge branch 'fix/electron_peerdependencies' of https://github.com/Ge…
JulienChampagnol 31c351d
closes #243
JulienChampagnol File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -34,6 +34,7 @@ | |
| "uuid": "11.1.0", | ||
| "vue3-carousel": "0.3.4", | ||
| "vuetify": "3.10.11", | ||
| "vuetify-nuxt-module": "0.18.7", | ||
| "ws": "8.18.3", | ||
| "wslink": "1.12.4" | ||
| }, | ||
|
|
@@ -61,6 +62,9 @@ | |
| "vitest": "4.0.15", | ||
| "vitest-environment-nuxt": "1.0.1" | ||
| }, | ||
| "peerDependencies": { | ||
| "electron": "36.4.0" | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. faut pas aussi rendre optionel l'import electron dans le code ? là c'est juste que le code client va pas réussir a s'executer si il n'a pas electron |
||
| }, | ||
| "overrides": { | ||
| "vue": "latest" | ||
| }, | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dans un isElectron() ? on fait des run_script en mode browser non ?