-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Added samples for secret rotations - create, update, delete #10226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Added samples for secret rotations - create, update, delete #10226
Conversation
…ion key and deleting annotations from the secret
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
… secret expiration times
Summary of ChangesHello @dhavalbhensdadiya-crest, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly expands the Google Cloud Secret Manager Java samples by introducing a suite of new examples for advanced secret management features. It provides clear, executable code for creating secrets with rotation policies, expiration times, customer-managed encryption keys (CMEK), and Pub/Sub topic notifications. Additionally, it includes samples for managing resource tags associated with secrets. These additions are available for both global and regional Secret Manager instances, enhancing the utility and completeness of the sample library for developers. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds a comprehensive set of new samples for Google Cloud Secret Manager, focusing on secret rotation, expiration, CMEK, topics, and tags for both global and regional secrets. The changes include new Java sample files, corresponding integration tests, and updates to the README with necessary setup instructions. The code is well-structured and the new samples are valuable additions. I have one suggestion to improve the clarity of the setup instructions in the README file.
|
|
||
| ```text | ||
| $ export GOOGLE_CLOUD_PROJECT=<your-project-id-here> | ||
| $ export GOOGLE_CLOUD_REGIONAL_KMS_KEY=<full-name-of-regional-kms-key> (region same as location) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The comment (region same as location) is a bit ambiguous and could lead to confusion. To improve clarity for users, it would be better to be more explicit about which location this refers to. For instance, you could clarify that it's the location used for regional secret samples.
| $ export GOOGLE_CLOUD_REGIONAL_KMS_KEY=<full-name-of-regional-kms-key> (region same as location) | |
| $ export GOOGLE_CLOUD_REGIONAL_KMS_KEY=<full-name-of-regional-kms-key> (region must match the location of regional secrets) |
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
… secret rotation policies and topics
ff1d1f0 to
51f9281
Compare
Description
Added samples for below operations in global and regional scope:
Fixes #
Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.
Checklist
pom.xmlparent set to latestshared-configurationmvn clean verifyrequiredmvn -P lint checkstyle:checkrequiredmvn -P lint clean compile pmd:cpd-check spotbugs:checkadvisory only