Skip to content

fix(functions): upgrade pubsub publish-message to Java 25 #10227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
alarconesparza wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix(functions): upgrade pubsub publish-message to Java 25 #10227

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 14 additions & 9 deletions functions/pubsub/publish-message/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,12 +27,12 @@
<parent>
<groupId>com.google.cloud.samples</groupId>
<artifactId>shared-configuration</artifactId>
<version>1.2.0</version>
<version>1.2.2</version>
</parent>

<properties>
<maven.compiler.target>11</maven.compiler.target>
<maven.compiler.source>11</maven.compiler.source>
<maven.compiler.target>25</maven.compiler.target>
<maven.compiler.source>25</maven.compiler.source>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
</properties>

Expand All @@ -41,7 +41,7 @@
<dependency>
<groupId>com.google.cloud</groupId>
<artifactId>libraries-bom</artifactId>
<version>26.32.0</version>
<version>26.73.0</version>
<type>pom</type>
<scope>import</scope>
</dependency>
Expand All @@ -58,15 +58,15 @@
<dependency>
<groupId>com.google.cloud.functions</groupId>
<artifactId>functions-framework-api</artifactId>
<version>1.1.0</version>
<version>2.0.0</version>
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Jan 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Upgrading functions-framework-api to version 2.0.0 is a major version bump. While the current function seems compatible, it's important to review the migration guide for functions-framework-api 2.0.0 to ensure there are no subtle breaking changes or recommended updates that should be applied to the function's implementation or its usage.

<scope>provided</scope>
</dependency>

<!-- The following dependencies are only required for testing -->
<dependency>
<groupId>com.google.truth</groupId>
<artifactId>truth</artifactId>
<version>1.4.0</version>
<version>1.4.5</version>
<scope>test</scope>
</dependency>
<dependency>
Expand All @@ -77,7 +77,7 @@
<dependency>
<groupId>org.mockito</groupId>
<artifactId>mockito-core</artifactId>
<version>5.10.0</version>
<version>5.21.0</version>
<scope>test</scope>
</dependency>
</dependencies>
Expand All @@ -96,7 +96,7 @@
-->
<groupId>com.google.cloud.functions</groupId>
<artifactId>function-maven-plugin</artifactId>
<version>0.11.0</version>
<version>1.0.0</version>
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Jan 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The function-maven-plugin has been upgraded to version 1.0.0. This is a major version release from 0.11.0. Please ensure that any migration steps or configuration changes required for this new major version have been addressed, even if the current configuration appears to work.

<configuration>
<functionTarget>functions.PublishMessage</functionTarget>
</configuration>
Expand All @@ -106,7 +106,7 @@
<artifactId>maven-surefire-plugin</artifactId>
<!-- version 3.0.0-M4 does not load JUnit5 correctly -->
<!-- see https://issues.apache.org/jira/browse/SUREFIRE-1750 -->
<version>3.2.5</version>
<version>3.5.4</version>
<configuration>
<includes>
<include>**/*Test.java</include>
Expand All @@ -116,6 +116,11 @@
<trimStackTrace>false</trimStackTrace>
</configuration>
</plugin>
<plugin>
<groupId>org.jacoco</groupId>
<artifactId>jacoco-maven-plugin</artifactId>
<version>0.8.14</version>
</plugin>
</plugins>
</build>
</project>