-
Notifications
You must be signed in to change notification settings - Fork 2.9k
chore(aiplatform): Change CreateBatchPredictionGeminiJobSample to use gemini 2.5 #10230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
chore(aiplatform): Change CreateBatchPredictionGeminiJobSample to use gemini 2.5 #10230
Conversation
Summary of ChangesHello @amcolin, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates a sample application to use a newer version of the Gemini model for batch prediction. This ensures the sample remains current with the latest available models, providing users with an up-to-date example of how to leverage advanced AI capabilities within their applications. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the model name used in the CreateBatchPredictionGeminiJobSample from gemini-2.0-flash-001 to gemini-2.5-flash. This change aligns with the pull request title and appears to be a direct update of the model version. The primary feedback concerns a maintainability improvement for the hardcoded model name.
| String.format( | ||
| "projects/%s/locations/%s/publishers/google/models/%s", | ||
| project, location, "gemini-2.0-flash-001"); | ||
| project, location, "gemini-2.5-flash"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The model name "gemini-2.5-flash" is hardcoded directly within the String.format call. For improved maintainability and to reduce the risk of typos, especially for critical API parameters like model names, it is generally a good practice to define such string literals as private static final String constants at the class level. This makes the value easier to locate and update if it changes in the future. Due to the constraint of only commenting on modified lines and providing compilable code suggestions, a direct code suggestion for adding a constant declaration is not provided here.
Description
Internal b/481401219
Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.
Checklist
pom.xmlparent set to latestshared-configurationmvn clean verifyrequiredmvn -P lint checkstyle:checkrequiredmvn -P lint clean compile pmd:cpd-check spotbugs:checkadvisory only