feat(secretmanager): Adding expiretime samples

[khilan-crest]

Adding expiretime samples

Fixes #

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

• I have followed guidelines from CONTRIBUTING.MD and Samples Style Guide
• Tests pass: npm test (see Testing)
• Lint pass: npm run lint (see Style)
• Required CI tests pass (see CI testing)
• These samples need a new API enabled in testing projects to pass (let us know which ones)
• These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
• This pull request is from a branch created directly off of GoogleCloudPlatform/nodejs-docs-samples. Not a fork.
• This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
• This sample adds a new sample directory, and I created GitHub Actions workflow for this sample
• This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
• Please merge this PR for me once it is approved

Note: Any check with (dev), (experimental), or (legacy) can be ignored and should not block your PR from merging (see CI testing).

[snippet-bot]

Here is the summary of changes.

You are about to add 17 region tags.

• secret-manager/createSecretWithCmek.js:18, tag secretmanager_create_secret_with_cmek
• secret-manager/createSecretWithExpiration.js:18, tag secretmanager_create_secret_with_expiration
• secret-manager/createSecretWithUserManagedReplicationPolicy.js:18, tag secretmanager_create_ummr_secret
• secret-manager/deleteSecretExpiration.js:18, tag secretmanager_delete_secret_expiration
• secret-manager/detachTagBinding.js:18, tag secretmanager_detach_tag_binding
• secret-manager/listSecretVersionsWithFilter.js:18, tag secretmanager_list_secret_versions_with_filter
• secret-manager/listSecretsWithFilter.js:18, tag secretmanager_list_secrets_with_filter
• secret-manager/listTagBindings.js:18, tag secretmanager_list_tag_bindings
• secret-manager/regional_samples/createRegionalSecretWithCmek.js:18, tag secretmanager_create_secret_with_cmek
• secret-manager/regional_samples/createRegionalSecretWithExpiration.js:18, tag secretmanager_create_regional_secret_with_expire_time
• secret-manager/regional_samples/deleteRegionalSecretExpiration.js:18, tag secretmanager_delete_regional_secret_expiration
• secret-manager/regional_samples/detachRegionalTag.js:18, tag secretmanager_detach_regional_tag
• secret-manager/regional_samples/listRegionalSecretVersionsWithFilter.js:18, tag secretmanager_list_regional_secret_versions_with_filter
• secret-manager/regional_samples/listRegionalSecretsWithFilter.js:18, tag secretmanager_list_regional_secrets_with_filter
• secret-manager/regional_samples/listRegionalTagBindings.js:18, tag secretmanager_list_regional_secret_tag_bindings
• secret-manager/regional_samples/updateRegionalSecretExpiration.js:18, tag secretmanager_update_regional_secret_expiration
• secret-manager/updateSecretExpiration.js:18, tag secretmanager_update_secret_expiration

---

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

• Refresh this comment

[gemini-code-assist]

Summary of Changes

Hello @khilan-crest, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the Google Cloud Secret Manager Node.js samples by introducing a suite of new functionalities. The additions focus on advanced secret management features, including the ability to define and manage secret expiration, utilize customer-managed encryption keys, and configure custom replication policies. Furthermore, the PR provides new ways to query and organize secrets through filtering and tag binding management. These updates aim to provide developers with clearer examples and broader coverage of the Secret Manager API's capabilities.

Highlights

• New Secret Expiration Samples: Added samples demonstrating how to create secrets with expiration times, update existing secret expiration times, and remove expiration from secrets, covering both global and regional Secret Manager instances.
• Customer-Managed Encryption Keys (CMEK) Samples: Introduced samples for creating secrets encrypted with Customer-Managed Encryption Keys (CMEK) for both global and regional Secret Manager services.
• User-Managed Replication Policy Sample: A new sample was added to illustrate the creation of secrets with user-managed replication policies, allowing specification of replica locations and an optional Time-To-Live (TTL).
• Filtering and Listing Samples: New samples provide functionality to list secrets and secret versions using filters, and to list and detach tag bindings from secrets, available for both global and regional contexts.
• Comprehensive Test Coverage: The test suite has been significantly expanded to include tests for all newly added samples, ensuring their correctness and proper cleanup of created resources.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request adds several new samples for Secret Manager, demonstrating features like expiration times, CMEK, user-managed replication, and tag management. The changes are comprehensive and cover both global and regional secrets.

My review has found a few issues:

• A recurring critical bug where asynchronous operations are not awaited, which would cause scripts to terminate prematurely.
• A bug in one sample where a parameter is passed with an incorrect type.
• Some opportunities for code simplification by removing unnecessarily nested functions.
• A minor inconsistency in code formatting.

I've provided specific suggestions to address these points in the comments below. Once these are addressed, the new samples will be much more robust and easier to understand.