Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion kms/attestations/requirements.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
cryptography==45.0.1
cryptography==46.0.5
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The updated cryptography version 46.x drops support for Python 3.7. To maintain compatibility for projects using Python 3.7 (as suggested by the conditional pem dependency), you should specify cryptography versions conditionally based on the Python version. This will ensure that a compatible version of cryptography is used for Python 3.7 environments.

cryptography==45.0.1; python_version < '3.8'
cryptography==46.0.5; python_version >= '3.8'

pem==21.2.0; python_version < '3.8'
pem==23.1.0; python_version > '3.7'
requests==2.31.0
2 changes: 1 addition & 1 deletion kms/snippets/requirements.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
google-cloud-kms==3.2.1
cryptography==45.0.1
cryptography==46.0.5
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The updated cryptography version 46.x drops support for Python 3.7. To avoid breaking environments using Python 3.7, you should specify cryptography versions conditionally. This ensures that projects relying on Python 3.7 do not fail during dependency installation.

cryptography==45.0.1; python_version < '3.8'
cryptography==46.0.5; python_version >= '3.8'

crcmod==1.7
jwcrypto==1.5.6
2 changes: 1 addition & 1 deletion privateca/snippets/requirements-test.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
pytest==8.2.0
google-auth==2.38.0
cryptography==45.0.1
cryptography==46.0.5
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The updated cryptography version 46.x drops support for Python 3.7. To avoid breaking test environments using Python 3.7, you should specify cryptography versions conditionally. This will ensure the test suite can run on older supported Python versions without installation issues.

cryptography==45.0.1; python_version < '3.8'
cryptography==46.0.5; python_version >= '3.8'

backoff==2.2.1