-
Notifications
You must be signed in to change notification settings - Fork 51
chore: bump sigs.k8s.io/kind from 0.30.0 to 0.31.0 #1966
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/test all |
Summary of ChangesHello @Camila-B, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request primarily focuses on upgrading the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request bumps the sigs.k8s.io/kind dependency from version 0.30.0 to 0.31.0. The changes primarily consist of updating the vendored code and adjusting the e2e test setup to be compatible with the new version. One notable change is the reduction of cluster creation retries in the tests, which could potentially affect test stability. Overall, the dependency update is handled correctly.
| // maxKindTries is the number of times to attempt to create a Kind cluster for | ||
| // a single test. | ||
| maxKindTries = 6 | ||
| maxKindTries = 2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reducing maxKindTries from 6 to 2 could potentially increase test flakiness if KinD cluster creation is not perfectly reliable. If cluster creation failures are still possible, it might be safer to keep a higher number of retries to ensure test stability. Consider reverting this change or monitoring test results closely for any increase in flakes related to cluster creation.
| maxKindTries = 2 | |
| maxKindTries = 6 |
|
Reading a bit more in the release note and see explicitly set apiVersion: kubeadm.k8s.io/v1beta3 https://github.com/kubernetes-sigs/kind/releases/tag/v0.31.0 |
Bumps [sigs.k8s.io/kind](https://github.com/kubernetes-sigs/kind) from 0.30.0 to 0.31.0. - [Release notes](https://github.com/kubernetes-sigs/kind/releases) - [Commits](kubernetes-sigs/kind@v0.30.0...v0.31.0) --- updated-dependencies: - dependency-name: sigs.k8s.io/kind dependency-version: 0.31.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
e15947c to
5bb3b04
Compare
|
/retest |
|
/retest |
|
@Camila-B: The following tests failed, say
DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
No description provided.