Skip to content

Conversation

@cowsking
Copy link
Contributor

Reverts #1972

Test failure for googleoss-kpt-config-sync-release/autopilot-stable. The root cause is an SSH authentication failure in the test harness, specifically: Host key verification failed.

This happened when the test runner tried to run a git push to the local test git server (localhost:40759). Because the push failed, the subsequent steps (reconciling the repo) never happened, leading to the root-reconciler deployment never being created (hence the NotFound errors later in the logs).

@gemini-code-assist
Copy link

Summary of Changes

Hello @cowsking, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request aims to stabilize the project's test suite by reverting a recent Go version upgrade. The previous bump to Go 1.24.11 introduced critical test failures related to SSH authentication within the testing environment, preventing the proper execution of subsequent test steps. By rolling back to Go 1.24.0, this change seeks to resolve these issues and restore the reliability of the automated tests.

Highlights

  • Revert Go Version Bump: This pull request reverts the previous change that updated the Go version to 1.24.11.
  • Addressing Test Failures: The revert is necessary due to test failures observed in the googleoss-kpt-config-sync-release/autopilot-stable suite, specifically an SSH authentication failure during git push operations in the test harness.
  • Restored Go Version: The go.mod file has been updated to use Go version 1.24.0.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly reverts the Go version in go.mod to 1.24.0 to resolve a test failure. However, a related change in the Makefile appears to have been missed. The GOLANG_IMAGE_VERSION is still set to 1.24.11, which creates an inconsistency between the project's declared Go version and the one used in the build environment. This could lead to subtle build and runtime issues. I strongly recommend reverting the GOLANG_IMAGE_VERSION in the Makefile as well to ensure a consistent and stable build process.

@cowsking cowsking force-pushed the revert-1972-fix-vulns-2 branch from a6e3cb1 to ca83af4 Compare December 30, 2025 03:04
@cowsking
Copy link
Contributor Author

/assign tiffanny29631

@tiffanny29631
Copy link
Contributor

Let's keep this PR a simple revert of #1972 and find out why the post sync would fail after the Go update.

@cowsking cowsking force-pushed the revert-1972-fix-vulns-2 branch from a556905 to a4a498d Compare December 30, 2025 07:05
Copy link
Contributor

@tiffanny29631 tiffanny29631 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Dec 30, 2025
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tiffanny29631

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit a21979f into GoogleContainerTools:main Dec 30, 2025
6 checks passed
tiffanny29631 added a commit to tiffanny29631/kpt-config-sync that referenced this pull request Jan 2, 2026
google-oss-prow bot pushed a commit that referenced this pull request Jan 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants