-
Notifications
You must be signed in to change notification settings - Fork 51
Revert "chore: bump to Go 1.24.11" #1973
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "chore: bump to Go 1.24.11" #1973
Conversation
Summary of ChangesHello @cowsking, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request aims to stabilize the project's test suite by reverting a recent Go version upgrade. The previous bump to Go 1.24.11 introduced critical test failures related to SSH authentication within the testing environment, preventing the proper execution of subsequent test steps. By rolling back to Go 1.24.0, this change seeks to resolve these issues and restore the reliability of the automated tests. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly reverts the Go version in go.mod to 1.24.0 to resolve a test failure. However, a related change in the Makefile appears to have been missed. The GOLANG_IMAGE_VERSION is still set to 1.24.11, which creates an inconsistency between the project's declared Go version and the one used in the build environment. This could lead to subtle build and runtime issues. I strongly recommend reverting the GOLANG_IMAGE_VERSION in the Makefile as well to ensure a consistent and stable build process.
a6e3cb1 to
ca83af4
Compare
|
/assign tiffanny29631 |
|
Let's keep this PR a simple revert of #1972 and find out why the post sync would fail after the Go update. |
This reverts commit d140183.
a556905 to
a4a498d
Compare
tiffanny29631
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tiffanny29631 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
a21979f
into
GoogleContainerTools:main
Reverts #1972
Test failure for googleoss-kpt-config-sync-release/autopilot-stable. The root cause is an SSH authentication failure in the test harness, specifically: Host key verification failed.
This happened when the test runner tried to run a git push to the local test git server (localhost:40759). Because the push failed, the subsequent steps (reconciling the repo) never happened, leading to the root-reconciler deployment never being created (hence the NotFound errors later in the logs).