You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I think it would be better to remove the line_index and word_index property from the VocalElements altogether and setup methods directly inside Lyrics to get adjacent elements. Also store elements directly inside lyrics using a matrix. The Line objects will not store the elements, instead would only contain other metadata and properties. This would probably cut down on the "rebuilding" that you are doing for now. That being said, I think it would be better to incorporate changes from the other branches before making breaking changes.
Why not just use a flag like part_of_word for that? If an element has been tagged with that then it and the next element would be part of a single word. Is probably more simple than what's done here
Yeah, but it wouldn't be efficient because you are destroying those objects every time the carousel moves. If you implement this, fps would probably tank.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds ability to edit vocal elements after importing them from a text file. This allows for the following
Closes #9