feat: Make search exclusions configurable via CodebaseContext #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces configurable search exclusions. Key changes: - Added `excluded_dirs` and `excluded_file_patterns` fields to the `CodebaseContext` model in `gemini_stacktrace/models/config.py`. These fields have sensible defaults for common project structures. - Modified the `find_in_files` and `_search_files` functions in `gemini_stacktrace/tools/codebase_tools.py` to respect these new configuration options, allowing you to customize which directories and file patterns are ignored during searches. - Updated unit tests in `tests/test_codebase_tools.py` to verify the functionality of default and custom exclusions. - Updated `docs/codebase_search.md` to document the new configuration options and how they can be used. This change allows for more flexible and precise control over the scope of codebase searches.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces configurable search exclusions.
Key changes:
excluded_dirsandexcluded_file_patternsfields to theCodebaseContextmodel ingemini_stacktrace/models/config.py. These fields have sensible defaults for common project structures.find_in_filesand_search_filesfunctions ingemini_stacktrace/tools/codebase_tools.pyto respect these new configuration options, allowing you to customize which directories and file patterns are ignored during searches.tests/test_codebase_tools.pyto verify the functionality of default and custom exclusions.docs/codebase_search.mdto document the new configuration options and how they can be used.This change allows for more flexible and precise control over the scope of codebase searches.