Add Dalli.close support to the storage adapter for use in process forking#41
Open
joellarsonibotta wants to merge 1 commit intomainfrom
Open
Add Dalli.close support to the storage adapter for use in process forking#41joellarsonibotta wants to merge 1 commit intomainfrom
joellarsonibotta wants to merge 1 commit intomainfrom
Conversation
…e in process forking
joellarsonibotta
force-pushed
the
feature/delegate-close-to-dalli-client
branch
from
375cc62 to
c1c96f1
Compare
lebeerman
approved these changes
Dec 28, 2021
Contributor
lebeerman
left a comment
lebeerman
left a comment
There was a problem hiding this comment.
This seems fine to do - not sure if adding example usage for why this would be necessary would benefit future gem users.
onyxraven
approved these changes
Jan 3, 2022
Contributor
|
Only other item here - probably want to bump the version to kick off the deploy: https://github.com/Ibotta/atomic_cache/blob/main/lib/atomic_cache/version.rb#L4 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
This change adds a delegation to Dalli.close for the Dalli storage adapter. It is useful when trying to clear Dalli connections when forking a process.
Tasks
./lib/atomic_cache/version.rb) when applicable