refactor(tests): moving to vitest initial commit #16781
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
projects/igniteui-angular/directives/src/directives/form-control/form-control.directive.spec.ts
Fixed
Show fixed
Hide fixed
| BaseFormatter, | ||
| I18N_FORMATTER | ||
| } from 'igniteui-angular/core'; | ||
| import { IgxOverlayOutletDirective, IgxOverlayService, OverlayCancelableEventArgs, OverlayClosingEventArgs, OverlayEventArgs, OverlaySettings, WEEKDAYS, BaseFormatter, I18N_FORMATTER } from 'igniteui-angular/core'; |
Member
Author
|
@copilot , can you fix the lint errors? |
Contributor
|
@ChronosSF I've opened a new pull request, #16782, to work on those changes. Once the pull request is ready, I'll request review from you. |
Co-authored-by: ChronosSF <2188411+ChronosSF@users.noreply.github.com>
fix(lint): resolve parsing errors and style violations from vitest migration
Member
Author
|
@copilot , this pr is meant to replace the old karma runner with vitest using playwright for browser mode. The automatic migration provided through a schematic left some issues. Use the CI build to check for errors and fix them. |
5 tasks
Contributor
|
@ChronosSF I've opened a new pull request, #16785, to work on those changes. Once the pull request is ready, I'll request review from you. |
Co-authored-by: ChronosSF <2188411+ChronosSF@users.noreply.github.com>
Co-authored-by: ChronosSF <2188411+ChronosSF@users.noreply.github.com>
fix(schematics): exclude spec files from build compilation
Member
Author
|
@copliot, fix test run errors by adding necessary imports. |
| ]); | ||
| const mockNgControl = { | ||
| writeValue: vi.fn().mockName("NgControl.writeValue"), | ||
| onChange: vi.fn().mockName("NgControl.onChange"), |
| import { NoopAnimationsModule } from '@angular/platform-browser/animations'; | ||
| import { IgxIconComponent } from 'igniteui-angular/icon'; | ||
| import { wait } from '../../../test-utils/ui-interactions.spec'; | ||
| import { describe, it, test, expect, beforeEach, vi } from 'vitest'; |
| import { IgxScrollInertiaDirective } from './scroll_inertia.directive'; | ||
|
|
||
| import { wait } from '../../../../test-utils/ui-interactions.spec'; | ||
| import { describe, it, test, expect, beforeEach, afterEach, vi } from 'vitest'; |
| import { FilteringExpressionsTree, FilteringLogic, IFilteringExpressionsTree, IGroupingExpression, IgxStringFilteringOperand, IPagingState, ISortingExpression, SortingDirection } from 'igniteui-angular/core'; | ||
| import { IgxHierarchicalGridComponent, IgxRowIslandComponent } from 'igniteui-angular/grids/hierarchical-grid'; | ||
| import { IgxGridNavigationService } from './grid-navigation.service'; | ||
| import { describe, it, test, expect, beforeEach, vi } from 'vitest'; |
| import { IgxGridComponent } from './grid.component'; | ||
| import { GridSelectionFunctions, GridFunctions } from '../../../test-utils/grid-functions.spec'; | ||
| import { ColumnType, SortingDirection } from 'igniteui-angular/core'; | ||
| import { describe, it, test, expect, beforeEach, vi } from 'vitest'; |
projects/igniteui-angular/grids/grid/src/grid-collapsible-columns.spec.ts
Fixed
Show fixed
Hide fixed
Member
Author
|
@copilot , in the CI run there are tests that throw errors for various reasons. Fix them. |
Contributor
|
@ChronosSF I've opened a new pull request, #16786, to work on those changes. Once the pull request is ready, I'll request review from you. |
- Add expect import to calendar-helper-utils.ts - Replace jasmine.getEnv() with vitest beforeEach/afterEach - Replace jasmine.createSpyObj with vi.fn() based mocks - Replace pending() with it.skip() - Fix expect() message syntax for vitest (message before assertion) - Remove deprecated exportExcel and exportCsv properties - Remove deprecated moveable property from column definitions - Fix mock emitter types to use any for compatibility Co-authored-by: ChronosSF <2188411+ChronosSF@users.noreply.github.com>
- Add GridPagingMode import and use GridPagingMode.Remote for RemotePagingComponent - Add GridSelectionMode import and use GridSelectionMode.none for MovableColumnsComponent - Add GridColumnDataType import and properly type columns in IgxGridAdvancedFilteringDynamicColumnsComponent Co-authored-by: ChronosSF <2188411+ChronosSF@users.noreply.github.com>
- Add isEditable, isHidden, isGroupable to MovableTemplatedColumnsComponent - Add paging property to MovableColumnsLargeComponent Co-authored-by: ChronosSF <2188411+ChronosSF@users.noreply.github.com>
fix(tests): Complete Vitest migration fixes for CI compilation errors
Member
Author
|
@copilot , in the spec files after migrating from jasmine to vitest there are a lot of instances where the message format for the asserts (expect clauses) is wrong and needs to be as a second argument to the expect call. Fix those. |
Contributor
|
@ChronosSF I've opened a new pull request, #16787, to work on those changes. Once the pull request is ready, I'll request review from you. |
Co-authored-by: ChronosSF <2188411+ChronosSF@users.noreply.github.com>
Co-authored-by: ChronosSF <2188411+ChronosSF@users.noreply.github.com>
fix(tests): migrate expect assertion messages to Vitest format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #
Additional information (check all that apply):
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes (migrations guidelines)