Skip to content

Conversation

@wnvko
Copy link
Contributor

@wnvko wnvko commented Jan 30, 2026

Closes #1481.

Move the teardown logic to chart specific test and remove the test.ts file as not needed anymore. Also fix a typo in linear gauge spec file.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR moves the Angular test environment teardown configuration from a global test.ts file to individual chart component test files and fixes a typo in the linear gauge component name.

Changes:

  • Removed the global test.ts file that configured teardown behavior for all tests
  • Added chart-specific teardown configuration to financial-chart and category-chart test files
  • Fixed typo in linear-gauge spec file where component name was missing the final 't'

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
packages/igx-templates/igx-ts/projects/_base/files/src/test.ts Deleted global test configuration file
packages/igx-templates/igx-ts/linear-gauge/default/files/src/app/path/filePrefix.component.spec.ts Fixed typo in component name from "Componen" to "Component"
packages/igx-templates/igx-ts/financial-chart/default/files/src/app/path/filePrefix.component.spec.ts Added teardown configuration to TestBed setup
packages/igx-templates/igx-ts/category-chart/default/files/src/app/path/filePrefix.component.spec.ts Added teardown configuration to TestBed setup

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@coveralls
Copy link

coveralls commented Jan 30, 2026

Coverage Status

coverage: 70.369%. remained the same
when pulling c35d3b3 on mvenkov/fix-chart-tests
into 603bf4f on master.

Hristo313
Hristo313 previously approved these changes Jan 30, 2026
Hristo313
Hristo313 previously approved these changes Jan 30, 2026
@dafo
Copy link
Collaborator

dafo commented Jan 30, 2026

The spec.ts tests are failing with errors like:
Chrome 144.0.0.0 (Windows 10) CategoryChartComponent should create FAILED zone-testing.js is needed for the async() test helper but could not be found. Please make sure that your environment includes zone.js/testing thrown
The tests are not failing on the master branch.

@wnvko
Copy link
Contributor Author

wnvko commented Jan 30, 2026

The spec.ts tests are failing with errors like: Chrome 144.0.0.0 (Windows 10) CategoryChartComponent should create FAILED zone-testing.js is needed for the async() test helper but could not be found. Please make sure that your environment includes zone.js/testing thrown The tests are not failing on the master branch.

This should be fixed now. We are providing the zone.js/testing in angular setup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Do not add globally destroyAfterEach for all tests

5 participants