Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a Roslyn diagnostic suppressor to prevent CA2000 false-positives when using Owned<T>.GetScope(out T) and introduces a dedicated test project to validate suppressor behavior.
Changes:
- Add
OwnedDisposableScopeSuppressor(suppresses CA2000 forOwned<T>.GetScope(out T)patterns). - Add suppressor test infrastructure and test cases for CA2000 suppression/non-suppression scenarios.
- Introduce an analyzers project and update packaging/solution/config to include it.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
src/Immediate.Cache.Analyzers/OwnedDisposableScopeSuppressor.cs |
New suppressor implementation for CA2000 around Owned<T>.GetScope(out T). |
src/Immediate.Cache.Analyzers/Immediate.Cache.Analyzers.csproj |
New Roslyn component project for analyzers/suppressors. |
tests/Immediate.Cache.Tests/SuppressorTests/SuppressorTestHelpers.cs |
Test helper utilities for running suppressor/analyzer tests. |
tests/Immediate.Cache.Tests/SuppressorTests/OwnedDisposableScopeSuppressorTests.cs |
New test coverage validating suppression behavior. |
tests/Immediate.Cache.Tests/Immediate.Cache.Tests.csproj |
New test project for analyzer/suppressor tests. |
src/Immediate.Cache/Immediate.Cache.csproj |
Packs the analyzer DLL with the main package and references the analyzer project. |
Directory.Packages.props |
Adds central package versions needed for analyzer testing / Roslyn dependencies. |
Immediate.Cache.slnx |
Adds the new analyzers project and test project to the solution. |
.editorconfig |
Updates analyzer severities and adds scoped rules (currently with a path typo). |
tests/Immediate.Cache.FunctionalTests/.editorconfig |
Removes per-project editorconfig in favor of root configuration. |
src/Immediate.Cache.Analyzers/OwnedDisposableScopeSuppressor.cs
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.