remove doc extraction, review, and dataset classes#212
Merged
Scott771 merged 1 commit intodev_6_14_2from Apr 1, 2025
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This pull request removes functionality that is no longer maintained or utilized, specifically eliminating classes and tests related to document extraction, reviewer handling, dataset operations, auto-population, and associated examples.
- Removed integration tests for Reviewer, DocExtraction, and Datasets.
- Removed corresponding modules and examples that depended on these functionalities.
- Updated import references across the codebase to reflect the removals.
Reviewed Changes
Copilot reviewed 24 out of 25 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/integration/indico_wrapper/test_reviewer.py | Removed tests related to reviewer functionality. |
| tests/integration/indico_wrapper/test_doc_extraction.py | Removed tests for document extraction features. |
| tests/integration/indico_wrapper/test_dataset.py | Removed tests for dataset functionality. |
| tests/integration/conftest.py | Removed fixtures that depended on the removed DocExtraction and related classes. |
| indico_toolkit/ocr/customocr_object.py | Removed the CustomOcr class, cleaning up unused OCR logic. |
| indico_toolkit/ocr/init.py | Updated all to reflect removal of CustomOcr. |
| indico_toolkit/indico_wrapper/reviewer.py | Removed the Reviewer class and its associated GraphQL queries. |
| indico_toolkit/indico_wrapper/doc_extraction.py | Removed the DocExtraction class handling OCR extraction. |
| indico_toolkit/indico_wrapper/dataset.py | Removed the Datasets class and its dataset management methods. |
| indico_toolkit/indico_wrapper/init.py | Removed references to the removed classes and updated exports accordingly. |
| indico_toolkit/auto_populate/types.py | Removed auto-populate type definitions. |
| indico_toolkit/auto_populate/populator.py | Removed the AutoPopulator class used for workflow and teach task population. |
| indico_toolkit/auto_populate/init.py | Removed auto_populate init file, cleaning up module exports. |
| examples/* | Removed multiple example scripts that relied on the removed functionalities. |
Files not reviewed (1)
- mypy.ini: Language not supported
mawelborn
approved these changes
Apr 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the beginning of removing functionality that is no longer maintained or utilized-- additional PRs will follow