Open
Conversation
…s the computation issue
…element from OneDPL
Contributor
|
View rendered docs @ https://intelpython.github.io/dpnp/pull/2766/index.html |
Contributor
|
Array API standard conformance tests for dpnp=0.20.0dev2=py313h509198e_28 ran successfully. |
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR propose to improve implementation and to use
dpnp.sortcall whenaxiskeyword is passed (previously not supported)kthis passed (previously not supported)In case of
ndim > 1previously the implementation from legacy backend was used, which is significantly slow (see performance comparation below). It used a copy of input data into the shared USM memory and included computations on the host.This PR proposes to reuse
dpnp.sortfor all the above cases.While in case when the legacy implementation is stable and fast (for 1D input array), it will remain, because it relays on
std::nth_elementfrom OneDPL.The benchmark results were collected on PVC with help of the below code:
Below tables contains data in case of 1D input array (shape=(10**7,)), where the implementation path was kept the same, plus adding support of missing integer dtypes using fallback on the sort function:
The following code was used for 2D input array with shape=(104, 104):
In that case the new implementation is fully based on the sort call: