Skip to content

Double Callback fixes proposal #978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
franco-zalamena-iterable wants to merge 3 commits into
base: master
Choose a base branch
from
+721 −157
Draft

Double Callback fixes proposal #978

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1102f24
Comments and changes to fix the double callback problem
franco-zalamena-iterable Jan 20, 2026
3f9c556
New Success Callbacks to handle different scenarios
franco-zalamena-iterable Jan 23, 2026
e7807fb
Fixed checkstyle fails and indentation fixes
franco-zalamena-iterable Jan 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 16 additions & 16 deletions integration-tests/src/main/java/com/iterable/integration/tests/utils/IntegrationTestUtils.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,14 +116,14 @@ class IntegrationTestUtils(private val context: Context) {
val response = httpClient.newCall(request).execute()
val success = response.isSuccessful

if (success) {
Log.d(TAG, "Campaign triggered successfully via API: campaignId=$campaignId, recipientEmail=$recipientEmail")
} else {
val errorBody = response.body?.string() ?: "No error body"
Log.e(TAG, "Failed to trigger campaign via API: ${response.code} - $errorBody")
// Store error message for UI display
lastErrorMessage = "HTTP ${response.code}: $errorBody"
}
if (success) {
Log.d(TAG, "Campaign triggered successfully via API: campaignId=$campaignId, recipientEmail=$recipientEmail")
} else {
val errorBody = response.body?.string() ?: "No error body"
Log.e(TAG, "Failed to trigger campaign via API: ${response.code} - $errorBody")
// Store error message for UI display
lastErrorMessage = "HTTP ${response.code}: $errorBody"
}

callback?.invoke(success)
} catch (e: Exception) {
Expand All @@ -149,14 +149,14 @@ class IntegrationTestUtils(private val context: Context) {
val response = httpClient.newCall(request).execute()
val success = response.isSuccessful

if (success) {
Log.d(TAG, "Push campaign triggered successfully via API: campaignId=$campaignId, recipientEmail=$recipientEmail")
} else {
val errorBody = response.body?.string() ?: "No error body"
Log.e(TAG, "Failed to trigger push campaign via API: ${response.code} - $errorBody")
// Store error message for UI display
lastErrorMessage = "HTTP ${response.code}: $errorBody"
}
if (success) {
Log.d(TAG, "Push campaign triggered successfully via API: campaignId=$campaignId, recipientEmail=$recipientEmail")
} else {
val errorBody = response.body?.string() ?: "No error body"
Log.e(TAG, "Failed to trigger push campaign via API: ${response.code} - $errorBody")
// Store error message for UI display
lastErrorMessage = "HTTP ${response.code}: $errorBody"
}
//TODO: Move callback success inside if(success)
callback?.invoke(success)
} catch (e: Exception) {
Expand Down
12 changes: 6 additions & 6 deletions iterableapi/src/androidTest/java/com/iterable/iterableapi/IterableApiResponseTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,10 +77,10 @@ public void testResponseCode200() throws Exception {
final JSONObject responseData = new JSONObject("{\"key\":\"value\"}");
stubAnyRequestReturningStatusCode(200, responseData);

IterableApiRequest request = new IterableApiRequest("fake_key", "", new JSONObject(), IterableApiRequest.POST, null, new IterableHelper.SuccessHandler() {
IterableApiRequest request = new IterableApiRequest("fake_key", "", new JSONObject(), IterableApiRequest.POST, null, new IterableHelper.RemoteSuccessCallback() {
@Override
public void onSuccess(@NonNull JSONObject data) {
assertEquals(responseData.toString(), data.toString());
public void onSuccess(@NonNull IterableResponseObject.RemoteSuccess data) {
assertEquals(responseData.toString(), data.getResponseJson().toString());
signal.countDown();
}
}, null);
Expand Down Expand Up @@ -222,11 +222,11 @@ public void onFailure(@NonNull String reason, @Nullable JSONObject data) {
"}");
stubAnyRequestReturningStatusCode(200, responseData);

new IterableRequestTask().execute(new IterableApiRequest("fake_key", "", new JSONObject(), IterableApiRequest.POST, null, new IterableHelper.SuccessHandler() {
new IterableRequestTask().execute(new IterableApiRequest("fake_key", "", new JSONObject(), IterableApiRequest.POST, null, new IterableHelper.RemoteSuccessCallback() {
@Override
public void onSuccess(@NonNull JSONObject successData) {
public void onSuccess(@NonNull IterableResponseObject.RemoteSuccess successData) {
try {
assertEquals(responseData.toString(), successData.toString());
assertEquals(responseData.toString(), successData.getResponseJson().toString());
} catch (AssertionError e) {
e.printStackTrace();
} finally {
Expand Down
Loading
Loading