fix(util): use using statement for JAction in Reset_AllowsReuse test #611
+1
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes CodeQL alert cs/dispose-not-called-on-throw. If Execute(), Reset(), or Do() threw an exception, Dispose() would not be called. Using a using declaration ensures the JAction is disposed even if an exception occurs. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> Signed-off-by: JasonXuDeveloper - 傑 <jason@xgamedev.net>
There was a problem hiding this comment.
Pull request overview
This PR updates a unit test to ensure a JAction instance is always disposed, even if an exception occurs during execution, addressing a CodeQL cs/dispose-not-called-on-throw alert.
Changes:
- Replace
var action = JAction.Create()withusing var action = JAction.Create()to guarantee disposal on all code paths. - Remove the now-redundant explicit
action.Dispose()call at the end of the test.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Unity Test Results✅ EditMode: All tests passed Unity Version: 2022.3.55f1 ✅ All tests passed! The PR is ready for review. View workflow run |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #611 +/- ##
===========================================
+ Coverage 42.84% 85.01% +42.17%
===========================================
Files 38 60 +22
Lines 4250 7683 +3433
===========================================
+ Hits 1821 6532 +4711
+ Misses 2429 1151 -1278
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
var actiontousing var actionto ensure disposal on exceptionProblem
The
Reset_AllowsReusetest created aJActionand calledDispose()at the end. However, ifExecute(),Reset(), orDo()threw an exception, the method would exit early andDispose()would never be called.Solution
Use a
usingdeclaration which guarantees disposal even when exceptions occur.Test plan
🤖 Generated with Claude Code