Skip to content

Change some overloads of ParticleEmitterNode.removeInfluencer methods… #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
NemesisMate wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Change some overloads of ParticleEmitterNode.removeInfluencer methods… #9

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions src/main/java/tonegod/emitter/ParticleEmitterNode.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1408,20 +1408,23 @@ public void removeInfluencer(@NotNull ParticleInfluencer<?> influencer) {
*
* @param index the influencer's index.
*/
public void removeInfluencer(int index) {

public ParticleInfluencer removeInfluencer(int index) {
ParticleInfluencer influencer = influencers.get(index);

if (index < 0) {
return;
}

storeInfluencerData(influencers.get(index), index);
storeInfluencerData(influencer, index);

for (int i = index, length = influencers.size(); i < length; i++) {
moveInfluencerData(i + 1, i);
}

influencers.remove(index);
requiresUpdate = true;

return influencer;
}

/**
Expand Down Expand Up @@ -1529,14 +1532,16 @@ protected void storeInfluencerData(@NotNull ParticleInfluencer<?> influencer, in
* @param <T> the influencer's type.
* @param type the class of the influencer to remove.
*/
public <T extends ParticleInfluencer<?>> void removeInfluencer(@NotNull Class<T> type) {

public <T extends ParticleInfluencer<?>> T removeInfluencer(@NotNull Class<T> type) {
T influencer = getInfluencer(type);

if (influencer == null) {
return;
}

removeInfluencer(influencer);

return influencer;
}

/**
Expand Down